You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wiedld (via GitHub)" <gi...@apache.org> on 2023/10/11 22:11:29 UTC

[PR] refactor(7181): move streaming_merge() into separate mod from the merge node [arrow-datafusion]

wiedld opened a new pull request, #7799:
URL: https://github.com/apache/arrow-datafusion/pull/7799

   ## Which issue does this PR close?
   Prerequisite for the cascading merge.
   Part of #7181 .
   
   ## Rationale for this change
   
   Create a new merge submodule which has the SortPreservingMergeStream (a.k.a. the loser tree). The SortPreservingMergeStream will be [used repeatedly](https://github.com/apache/arrow-datafusion/blob/9b1019853fb3d71f6355ab1d850089332592b3d8/datafusion/physical-plan/src/sorts/cascade.rs#L43-L75) as part of the cascading merge tree.
   
   By comparison, the streaming_merge() method will only be called once -- by the cascading struct (in the cascade submodule).
   
   ## What changes are included in this PR?
   
   See above.
   
   ## Are these changes tested?
   
   Only moving code. Nothing change.
   
   ## Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(7181): move streaming_merge() into separate mod from the merge node [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7799:
URL: https://github.com/apache/arrow-datafusion/pull/7799#issuecomment-1761692285

   Thank you 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(7181): move streaming_merge() into separate mod from the merge node [arrow-datafusion]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #7799:
URL: https://github.com/apache/arrow-datafusion/pull/7799


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org