You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Alexander Dejanovski (Jira)" <ji...@apache.org> on 2020/11/17 14:36:00 UTC

[jira] [Created] (CASSANDRA-16280) SSTableLoader will fail if encryption parameters are used due to CASSANDRA-16144

Alexander Dejanovski created CASSANDRA-16280:
------------------------------------------------

             Summary: SSTableLoader will fail if encryption parameters are used due to CASSANDRA-16144
                 Key: CASSANDRA-16280
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16280
             Project: Cassandra
          Issue Type: Bug
            Reporter: Alexander Dejanovski
            Assignee: Alexander Dejanovski


CASSANDRA-16144 recently introduced [repeated calls |https://github.com/apache/cassandra/compare/trunk...dcapwell:commit_remote_branch/CASSANDRA-16144-trunk-209E2350-3A50-457E-A466-F2661CD0D4D1#diff-b87acacbdc34464d327446f7a7e64718dbf843d70f5fbc9e5ddcd1bafca0f441R478]to _clientEncOptions.applyConfig()_ for each encryption parameter passed to the sstableloader command line.
This consistently fails because _applyConfig()_ can be called only once due to the _ensureConfigNotApplied()_ check at the beginning of the method.

This call is not necessary since the _with...()_ methods will invoke _applyConfig()_ each time:
{code:java}
public EncryptionOptions withTrustStore(String truststore)
{
    return new EncryptionOptions(keystore, keystore_password, truststore, truststore_password, cipher_suites,
                                        protocol, algorithm, store_type, require_client_auth, require_endpoint_verification,
                                        enabled, optional).applyConfig();
}
{code}
I'll build a patch for this with the appropriate unit test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org