You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/23 12:07:24 UTC
[GitHub] [arrow-datafusion] ming535 opened a new pull request, #2597: fix some typos
ming535 opened a new pull request, #2597:
URL: https://github.com/apache/arrow-datafusion/pull/2597
# Which issue does this PR close?
NA
# Rationale for this change
fix typo
# What changes are included in this PR?
# Are there any user-facing changes?
NO
# Does this PR break compatibility with Ballista?
NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] waynexia commented on pull request #2597: fix some typos
Posted by GitBox <gi...@apache.org>.
waynexia commented on PR #2597:
URL: https://github.com/apache/arrow-datafusion/pull/2597#issuecomment-1134641505
There is another `identifer` in https://github.com/apache/arrow-datafusion/blob/33dcd0273d92936e02237533d4acdef18b4922ba/datafusion/core/src/sql/utils.rs#L474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a diff in pull request #2597: fix some typos
Posted by GitBox <gi...@apache.org>.
xudong963 commented on code in PR #2597:
URL: https://github.com/apache/arrow-datafusion/pull/2597#discussion_r879392206
##########
datafusion/core/src/sql/utils.rs:
##########
@@ -471,7 +471,7 @@ pub(crate) fn make_decimal_type(
}
}
-// Normalize an identifer to a lowercase string unless the identifier is quoted.
Review Comment:
Could you please replace all `identifer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 merged pull request #2597: fix some typos
Posted by GitBox <gi...@apache.org>.
xudong963 merged PR #2597:
URL: https://github.com/apache/arrow-datafusion/pull/2597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org