You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/17 00:37:52 UTC
[GitHub] [superset] jdbranham opened a new pull request, #19744: fix(webpack-dev-server): parse env args
jdbranham opened a new pull request, #19744:
URL: https://github.com/apache/superset/pull/19744
### SUMMARY
The `--superset` arg is rejected by webpack because it's not well known.
This PR updates the documentation and changes the flag to use the `--env` arg as a way to override the backend superset environment when running the `webpack-dev-server`.
### TESTING INSTRUCTIONS
From the `superset-frontend` directory, run the command to use a remote superset backend.
```bash
npm run dev-server -- --env=--superset=https://my-superset-backend
```
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #19743
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(webpack-dev-server): parse env args [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #19744:
URL: https://github.com/apache/superset/pull/19744#issuecomment-1930727701
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/19744?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`ae70212`)](https://app.codecov.io/gh/apache/superset/commit/ae70212df31e4e483a9c316898419a55389fe619?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 66.51% compared to head [(`2c4396c`)](https://app.codecov.io/gh/apache/superset/pull/19744?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.43%.
> Report is 3191 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19744 +/- ##
==========================================
+ Coverage 66.51% 68.43% +1.92%
==========================================
Files 1687 1840 +153
Lines 64623 70219 +5596
Branches 6646 8275 +1629
==========================================
+ Hits 42983 48054 +5071
- Misses 19940 20114 +174
- Partials 1700 2051 +351
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/19744/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/19744/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.91% <ø> (+5.72%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/19744?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(webpack-dev-server): parse env args [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19744:
URL: https://github.com/apache/superset/pull/19744#issuecomment-1930677425
Sorry this never got a review somehow. Adding a few folks to review/test this. I'm also closing/reopening to kick-start CI, and see if we can get this thing across the finish line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(webpack-dev-server): parse env args [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #19744: fix(webpack-dev-server): parse env args
URL: https://github.com/apache/superset/pull/19744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(webpack-dev-server): parse env args [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #19744:
URL: https://github.com/apache/superset/pull/19744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] vivostar commented on pull request #19744: fix(webpack-dev-server): parse env args
Posted by GitBox <gi...@apache.org>.
vivostar commented on PR #19744:
URL: https://github.com/apache/superset/pull/19744#issuecomment-1175756756
+1, the patch work well on my local dev environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] TacoBel42 commented on pull request #19744: fix(webpack-dev-server): parse env args
Posted by "TacoBel42 (via GitHub)" <gi...@apache.org>.
TacoBel42 commented on PR #19744:
URL: https://github.com/apache/superset/pull/19744#issuecomment-1404783189
that solved connection problem, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org