You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "guozhangwang (via GitHub)" <gi...@apache.org> on 2023/01/26 01:08:52 UTC
[GitHub] [kafka] guozhangwang opened a new pull request, #13167: KAFKA-14650: Synchronize access to tasks inside task manager
guozhangwang opened a new pull request, #13167:
URL: https://github.com/apache/kafka/pull/13167
1) The major fix: synchronize access to tasks inside task manager.
2) Clarify on func names of StreamThread that maybe triggered outside the StreamThread.
3) Minor cleanups.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #13167: KAFKA-14650: Synchronize access to tasks inside task manager
Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang merged PR #13167:
URL: https://github.com/apache/kafka/pull/13167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #13167: KAFKA-14650: Synchronize access to tasks inside task manager
Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang commented on PR #13167:
URL: https://github.com/apache/kafka/pull/13167#issuecomment-1410914374
@lucasbru You're right! I think this issue exists even before #12397.
After thinking that a bit, along with forward looking that IQ would need to access the Tasks plus the StateUpdater (which is already synchronized) I'll just synchronize on the access of the two maps instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #13167: KAFKA-14650: Synchronize access to tasks inside task manager
Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang commented on PR #13167:
URL: https://github.com/apache/kafka/pull/13167#issuecomment-1404437326
ping @cadonna for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org