You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "AmatyaAvadhanula (via GitHub)" <gi...@apache.org> on 2024/02/06 10:36:13 UTC
[PR] Simplify concurrent streaming ingestion with replace (druid)
AmatyaAvadhanula opened a new pull request, #15844:
URL: https://github.com/apache/druid/pull/15844
This PR aims to simplify the working of a concurrent streaming ingestion job with a replacing commit.
The original approach required us to update the pending segments and send the mapping to the peon, and this can be error-prone with uncertainties.
This approach is as follows:
When a segment is upgraded to another segment of a higher version, we store the original id as a descriptor in the newly created segment.
The CachingClusteredClient on the Broker then includes all overshadowed realtime segments (if any), except the higher versions of them which already exist on historicals. The filtered set of realtime segments are then included along with the segments returned by the lookup of the complete timeline in the set of segments to be processed.
TODO:
- Evaluate performance impact on queries
- Clean up the pending segment and task communication methods used in the original approach
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Simplify concurrent streaming ingestion with replace (druid)
Posted by "AmatyaAvadhanula (via GitHub)" <gi...@apache.org>.
AmatyaAvadhanula commented on PR #15844:
URL: https://github.com/apache/druid/pull/15844#issuecomment-2005937936
Closing this in favor of a different approach in https://github.com/apache/druid/pull/16144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Simplify concurrent streaming ingestion with replace (druid)
Posted by "AmatyaAvadhanula (via GitHub)" <gi...@apache.org>.
AmatyaAvadhanula closed pull request #15844: Simplify concurrent streaming ingestion with replace
URL: https://github.com/apache/druid/pull/15844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org