You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Jaideep dhok <ja...@inmobi.com> on 2015/01/28 07:48:07 UTC
Review Request 30359: LENS-35 Queries failing with monthly time range
at hourly granularity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/
-----------------------------------------------------------
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-35
https://issues.apache.org/jira/browse/LENS-35
Repository: lens
Description
-------
LENS-35 Queries failing with monthly time range at hourly granularity
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java PRE-CREATION
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
Diff: https://reviews.apache.org/r/30359/diff/
Testing
-------
Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
Running all tests, will update once done
Thanks,
Jaideep dhok
Re: Review Request 30359: LENS-35 Queries failing with monthly time
range at hourly granularity
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/#review69979
-----------------------------------------------------------
overall changes look fine.
lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java
<https://reviews.apache.org/r/30359/#comment114871>
Can you add comment for this - what is being done? and also update unit test for these changes?
- Amareshwari Sriramadasu
On Jan. 28, 2015, 7:13 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30359/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 7:13 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-35
> https://issues.apache.org/jira/browse/LENS-35
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-35 Queries failing with monthly time range at hourly granularity
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
>
> Diff: https://reviews.apache.org/r/30359/diff/
>
>
> Testing
> -------
>
> Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
> [INFO] Lens .............................................. SUCCESS [1.473s]
> [INFO] Lens API .......................................... SUCCESS [16.719s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
> [INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
> [INFO] Lens DB storage ................................... SUCCESS [36.185s]
> [INFO] Lens Query Library ................................ SUCCESS [9.052s]
> [INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
> [INFO] Lens Server ....................................... SUCCESS [17:16.966s]
> [INFO] Lens client ....................................... SUCCESS [33.318s]
> [INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
> [INFO] Lens Examples ..................................... SUCCESS [2.249s]
> [INFO] Lens Distribution ................................. SUCCESS [0.468s]
> [INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
> [INFO] Lens Regression ................................... SUCCESS [0.417s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:24.593s
> [INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
> [INFO] Final Memory: 113M/582M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 30359: LENS-35 Queries failing with monthly time
range at hourly granularity
Posted by Jaideep dhok <ja...@inmobi.com>.
> On Jan. 28, 2015, 10:35 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java, line 48
> > <https://reviews.apache.org/r/30359/diff/2/?file=838583#file838583line48>
> >
> > This change wont put the filters correctly.
> >
> > For we have :
> > (it = d1 or d2 or .... d27) or
> > (pt=d28-00 and it=d27-22) or (pt=d28-00 and it=d27-23)
> >
> > This will change pt in (d28-00) and it in ( d1, d2, ..., d27, d27-22, d27-23).
> >
> > The above change is losing the coupling of AND constraint between pt and it.
Planning to use a hybrid approach
1. If the time range filter contains multiple columns, use it as is, and combine all such filters with an OR
2. If the time range filter contains only a single column all filters for that column will be combined in an IN clause
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/#review69986
-----------------------------------------------------------
On Jan. 28, 2015, 10:13 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30359/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 10:13 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-35
> https://issues.apache.org/jira/browse/LENS-35
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-35 Queries failing with monthly time range at hourly granularity
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
>
> Diff: https://reviews.apache.org/r/30359/diff/
>
>
> Testing
> -------
>
> Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
> [INFO] Lens .............................................. SUCCESS [1.473s]
> [INFO] Lens API .......................................... SUCCESS [16.719s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
> [INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
> [INFO] Lens DB storage ................................... SUCCESS [36.185s]
> [INFO] Lens Query Library ................................ SUCCESS [9.052s]
> [INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
> [INFO] Lens Server ....................................... SUCCESS [17:16.966s]
> [INFO] Lens client ....................................... SUCCESS [33.318s]
> [INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
> [INFO] Lens Examples ..................................... SUCCESS [2.249s]
> [INFO] Lens Distribution ................................. SUCCESS [0.468s]
> [INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
> [INFO] Lens Regression ................................... SUCCESS [0.417s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:24.593s
> [INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
> [INFO] Final Memory: 113M/582M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 30359: LENS-35 Queries failing with monthly time
range at hourly granularity
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/#review69986
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java
<https://reviews.apache.org/r/30359/#comment114903>
This change wont put the filters correctly.
For we have :
(it = d1 or d2 or .... d27) or
(pt=d28-00 and it=d27-22) or (pt=d28-00 and it=d27-23)
This will change pt in (d28-00) and it in ( d1, d2, ..., d27, d27-22, d27-23).
The above change is losing the coupling of AND constraint between pt and it.
- Amareshwari Sriramadasu
On Jan. 28, 2015, 10:13 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30359/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 10:13 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-35
> https://issues.apache.org/jira/browse/LENS-35
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-35 Queries failing with monthly time range at hourly granularity
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
>
> Diff: https://reviews.apache.org/r/30359/diff/
>
>
> Testing
> -------
>
> Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
> [INFO] Lens .............................................. SUCCESS [1.473s]
> [INFO] Lens API .......................................... SUCCESS [16.719s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
> [INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
> [INFO] Lens DB storage ................................... SUCCESS [36.185s]
> [INFO] Lens Query Library ................................ SUCCESS [9.052s]
> [INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
> [INFO] Lens Server ....................................... SUCCESS [17:16.966s]
> [INFO] Lens client ....................................... SUCCESS [33.318s]
> [INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
> [INFO] Lens Examples ..................................... SUCCESS [2.249s]
> [INFO] Lens Distribution ................................. SUCCESS [0.468s]
> [INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
> [INFO] Lens Regression ................................... SUCCESS [0.417s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:24.593s
> [INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
> [INFO] Final Memory: 113M/582M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 30359: LENS-35 Queries failing with monthly time
range at hourly granularity
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/#review70002
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Jan. 28, 2015, 12:33 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30359/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 12:33 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-35
> https://issues.apache.org/jira/browse/LENS-35
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-35 Queries failing with monthly time range at hourly granularity
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
>
> Diff: https://reviews.apache.org/r/30359/diff/
>
>
> Testing
> -------
>
> Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
> [INFO] Lens .............................................. SUCCESS [1.473s]
> [INFO] Lens API .......................................... SUCCESS [16.719s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
> [INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
> [INFO] Lens DB storage ................................... SUCCESS [36.185s]
> [INFO] Lens Query Library ................................ SUCCESS [9.052s]
> [INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
> [INFO] Lens Server ....................................... SUCCESS [17:16.966s]
> [INFO] Lens client ....................................... SUCCESS [33.318s]
> [INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
> [INFO] Lens Examples ..................................... SUCCESS [2.249s]
> [INFO] Lens Distribution ................................. SUCCESS [0.468s]
> [INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
> [INFO] Lens Regression ................................... SUCCESS [0.417s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:24.593s
> [INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
> [INFO] Final Memory: 113M/582M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 30359: LENS-35 Queries failing with monthly time
range at hourly granularity
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/
-----------------------------------------------------------
(Updated Jan. 28, 2015, 12:33 p.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Updated comment
Bugs: LENS-35
https://issues.apache.org/jira/browse/LENS-35
Repository: lens
Description
-------
LENS-35 Queries failing with monthly time range at hourly granularity
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java PRE-CREATION
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
Diff: https://reviews.apache.org/r/30359/diff/
Testing
-------
Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
[INFO] Lens .............................................. SUCCESS [1.473s]
[INFO] Lens API .......................................... SUCCESS [16.719s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
[INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
[INFO] Lens DB storage ................................... SUCCESS [36.185s]
[INFO] Lens Query Library ................................ SUCCESS [9.052s]
[INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
[INFO] Lens Server ....................................... SUCCESS [17:16.966s]
[INFO] Lens client ....................................... SUCCESS [33.318s]
[INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
[INFO] Lens Examples ..................................... SUCCESS [2.249s]
[INFO] Lens Distribution ................................. SUCCESS [0.468s]
[INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
[INFO] Lens Regression ................................... SUCCESS [0.417s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:24.593s
[INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
[INFO] Final Memory: 113M/582M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok
Re: Review Request 30359: LENS-35 Queries failing with monthly time
range at hourly granularity
Posted by Jaideep dhok <ja...@inmobi.com>.
> On Jan. 28, 2015, 12:29 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java, line 75
> > <https://reviews.apache.org/r/30359/diff/3/?file=838623#file838623line75>
> >
> > Is this still required?
Yes
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/#review69999
-----------------------------------------------------------
On Jan. 28, 2015, 12:33 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30359/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 12:33 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-35
> https://issues.apache.org/jira/browse/LENS-35
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-35 Queries failing with monthly time range at hourly granularity
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
>
> Diff: https://reviews.apache.org/r/30359/diff/
>
>
> Testing
> -------
>
> Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
> [INFO] Lens .............................................. SUCCESS [1.473s]
> [INFO] Lens API .......................................... SUCCESS [16.719s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
> [INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
> [INFO] Lens DB storage ................................... SUCCESS [36.185s]
> [INFO] Lens Query Library ................................ SUCCESS [9.052s]
> [INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
> [INFO] Lens Server ....................................... SUCCESS [17:16.966s]
> [INFO] Lens client ....................................... SUCCESS [33.318s]
> [INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
> [INFO] Lens Examples ..................................... SUCCESS [2.249s]
> [INFO] Lens Distribution ................................. SUCCESS [0.468s]
> [INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
> [INFO] Lens Regression ................................... SUCCESS [0.417s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:24.593s
> [INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
> [INFO] Final Memory: 113M/582M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 30359: LENS-35 Queries failing with monthly time
range at hourly granularity
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/#review69999
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java
<https://reviews.apache.org/r/30359/#comment114926>
Can you update comment here?
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java
<https://reviews.apache.org/r/30359/#comment114927>
Is this still required?
- Amareshwari Sriramadasu
On Jan. 28, 2015, 12:03 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30359/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 12:03 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-35
> https://issues.apache.org/jira/browse/LENS-35
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-35 Queries failing with monthly time range at hourly granularity
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
>
> Diff: https://reviews.apache.org/r/30359/diff/
>
>
> Testing
> -------
>
> Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
> [INFO] Lens .............................................. SUCCESS [1.473s]
> [INFO] Lens API .......................................... SUCCESS [16.719s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
> [INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
> [INFO] Lens DB storage ................................... SUCCESS [36.185s]
> [INFO] Lens Query Library ................................ SUCCESS [9.052s]
> [INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
> [INFO] Lens Server ....................................... SUCCESS [17:16.966s]
> [INFO] Lens client ....................................... SUCCESS [33.318s]
> [INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
> [INFO] Lens Examples ..................................... SUCCESS [2.249s]
> [INFO] Lens Distribution ................................. SUCCESS [0.468s]
> [INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
> [INFO] Lens Regression ................................... SUCCESS [0.417s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:24.593s
> [INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
> [INFO] Final Memory: 113M/582M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 30359: LENS-35 Queries failing with monthly time
range at hourly granularity
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/
-----------------------------------------------------------
(Updated Jan. 28, 2015, 12:03 p.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Using hybrid approach to incorporate multiple partition columns.
Example rewritten query -
```
@@ HQL with IN and OR: SELECT ( testcube . dim1 ), max(( testcube . msr3 )), sum(( testcube . msr2 )) FROM TestQueryRewrite.c2_summary1 testcube WHERE ((testcube.pt != 'latest' AND testcube.et != 'latest') AND (((((((( testcube . pt ) = '2015-01-28-00' ) and (( testcube . it ) = '2015-01-27-20' )) or ((( testcube . pt ) = '2015-01-28-01' ) and (( testcube . it ) = '2015-01-27-21' ))) or ((( testcube . pt ) = '2015-01-28-02' ) and (( testcube . it ) = '2015-01-27-22' ))) or ((( testcube . pt ) = '2015-01-28-03' ) and (( testcube . it ) = '2015-01-27-23' ))) or ( testcube . it ) in ( '2015-01-26-17' , '2015-01-26-18' , '2015-01-26-19' , '2015-01-26-20' , '2015-01-26-21' , '2015-01-26-22' , '2015-01-26-23' , '2015-01-27' , '2015-01-28-00' , '2015-01-28-01' , '2015-01-28-02' , '2015-01-28-03' , '2015-01-28-04' , '2015-01-28-05' , '2015-01-28-06' , '2015-01-28-07' , '2015-01-28-08' , '2015-01-28-09' , '2015-01-28-10' , '2015-01-28-11' , '201
5-01-28-12' , '2015-01-28-13' , '2015-01-28-14' , '2015-01-28-15' , '2015-01-28-16' )))) GROUP BY ( testcube . dim1 )
```
Bugs: LENS-35
https://issues.apache.org/jira/browse/LENS-35
Repository: lens
Description
-------
LENS-35 Queries failing with monthly time range at hourly granularity
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java PRE-CREATION
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
Diff: https://reviews.apache.org/r/30359/diff/
Testing
-------
Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
[INFO] Lens .............................................. SUCCESS [1.473s]
[INFO] Lens API .......................................... SUCCESS [16.719s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
[INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
[INFO] Lens DB storage ................................... SUCCESS [36.185s]
[INFO] Lens Query Library ................................ SUCCESS [9.052s]
[INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
[INFO] Lens Server ....................................... SUCCESS [17:16.966s]
[INFO] Lens client ....................................... SUCCESS [33.318s]
[INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
[INFO] Lens Examples ..................................... SUCCESS [2.249s]
[INFO] Lens Distribution ................................. SUCCESS [0.468s]
[INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
[INFO] Lens Regression ................................... SUCCESS [0.417s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:24.593s
[INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
[INFO] Final Memory: 113M/582M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok
Re: Review Request 30359: LENS-35 Queries failing with monthly time
range at hourly granularity
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/
-----------------------------------------------------------
(Updated Jan. 28, 2015, 10:13 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Updated based on review comments.
Bugs: LENS-35
https://issues.apache.org/jira/browse/LENS-35
Repository: lens
Description
-------
LENS-35 Queries failing with monthly time range at hourly granularity
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java PRE-CREATION
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
Diff: https://reviews.apache.org/r/30359/diff/
Testing
-------
Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
[INFO] Lens .............................................. SUCCESS [1.473s]
[INFO] Lens API .......................................... SUCCESS [16.719s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
[INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
[INFO] Lens DB storage ................................... SUCCESS [36.185s]
[INFO] Lens Query Library ................................ SUCCESS [9.052s]
[INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
[INFO] Lens Server ....................................... SUCCESS [17:16.966s]
[INFO] Lens client ....................................... SUCCESS [33.318s]
[INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
[INFO] Lens Examples ..................................... SUCCESS [2.249s]
[INFO] Lens Distribution ................................. SUCCESS [0.468s]
[INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
[INFO] Lens Regression ................................... SUCCESS [0.417s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:24.593s
[INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
[INFO] Final Memory: 113M/582M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok
Re: Review Request 30359: LENS-35 Queries failing with monthly time
range at hourly granularity
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/#review69980
-----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
<https://reviews.apache.org/r/30359/#comment114874>
Should have an assert on the presence of `IN` clause.
- Rajat Khandelwal
On Jan. 28, 2015, 7:13 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30359/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 7:13 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-35
> https://issues.apache.org/jira/browse/LENS-35
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-35 Queries failing with monthly time range at hourly granularity
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
>
> Diff: https://reviews.apache.org/r/30359/diff/
>
>
> Testing
> -------
>
> Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
> [INFO] Lens .............................................. SUCCESS [1.473s]
> [INFO] Lens API .......................................... SUCCESS [16.719s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
> [INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
> [INFO] Lens DB storage ................................... SUCCESS [36.185s]
> [INFO] Lens Query Library ................................ SUCCESS [9.052s]
> [INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
> [INFO] Lens Server ....................................... SUCCESS [17:16.966s]
> [INFO] Lens client ....................................... SUCCESS [33.318s]
> [INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
> [INFO] Lens Examples ..................................... SUCCESS [2.249s]
> [INFO] Lens Distribution ................................. SUCCESS [0.468s]
> [INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
> [INFO] Lens Regression ................................... SUCCESS [0.417s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:24.593s
> [INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
> [INFO] Final Memory: 113M/582M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 30359: LENS-35 Queries failing with monthly time
range at hourly granularity
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/
-----------------------------------------------------------
(Updated Jan. 28, 2015, 7:13 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Updated test results
Bugs: LENS-35
https://issues.apache.org/jira/browse/LENS-35
Repository: lens
Description
-------
LENS-35 Queries failing with monthly time range at hourly granularity
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java PRE-CREATION
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 6733e4adb423238b9e4f326219092960a57d2b45
Diff: https://reviews.apache.org/r/30359/diff/
Testing (updated)
-------
Added unit test to validate that partition in clause gets parsed successfully. Also validated failure with OR partition clause.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
[INFO] Lens .............................................. SUCCESS [1.473s]
[INFO] Lens API .......................................... SUCCESS [16.719s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
[INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
[INFO] Lens DB storage ................................... SUCCESS [36.185s]
[INFO] Lens Query Library ................................ SUCCESS [9.052s]
[INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
[INFO] Lens Server ....................................... SUCCESS [17:16.966s]
[INFO] Lens client ....................................... SUCCESS [33.318s]
[INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
[INFO] Lens Examples ..................................... SUCCESS [2.249s]
[INFO] Lens Distribution ................................. SUCCESS [0.468s]
[INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
[INFO] Lens Regression ................................... SUCCESS [0.417s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:24.593s
[INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
[INFO] Final Memory: 113M/582M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok