Re: [PR] Core, Data: File Format API interfaces [iceberg]

["pvary (via GitHub)" <gi...@apache.org>]

pvary commented on code in PR #12774:
URL: https://github.com/apache/iceberg/pull/12774#discussion_r2768937825


##########
core/src/main/java/org/apache/iceberg/deletes/PositionDeleteWriter.java:
##########
@@ -60,7 +60,7 @@ public class PositionDeleteWriter<T> implements FileWriter<PositionDelete<T>, De
   private DeleteFile deleteFile = null;
 
   public PositionDeleteWriter(
-      FileAppender<StructLike> appender,
+      FileAppender<PositionDelete<T>> appender,

Review Comment:
   We should double‑check this. While it is not a binary breaking change due to type erasure, it could still be a source‑level breaking change if external users are using this class with concrete StructLike writers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org