[jira] [Commented] (HDFS-6150) Add inode id information in the logs to make debugging easier

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945823#comment-13945823 ] 

Tsz Wo Nicholas Sze commented on HDFS-6150:
-------------------------------------------

In the existing code, there are two places below that it says "Failed to ... " + src + " on client " + clientMachine.  It seems saying the src is "on" the client machine.  It should be "for" the client.  Could you also fix it as well?
{code}
@@ -2292,8 +2292,8 @@ private void startFileInternal(FSPermissionChecker pc, String src,
     try {
       if (myFile == null) {
         if (!create) {
-          throw new FileNotFoundException("failed to overwrite non-existent file "
-            + src + " on client " + clientMachine);
+          throw new FileNotFoundException("Can't overwrite non-existent " +
+              src + " on client " + clientMachine);
         }
       } else {
         if (overwrite) {
@@ -2306,8 +2306,8 @@ private void startFileInternal(FSPermissionChecker pc, String src,
         } else {
           // If lease soft limit time is expired, recover the lease
           recoverLeaseInternal(myFile, src, holder, clientMachine, false);
-          throw new FileAlreadyExistsException("failed to create file " + src
-              + " on client " + clientMachine + " because the file exists");
+          throw new FileAlreadyExistsException(src + " on client " +
+              clientMachine + " already exists");
         }
       }
{code}


> Add inode id information in the logs to make debugging easier
> -------------------------------------------------------------
>
>                 Key: HDFS-6150
>                 URL: https://issues.apache.org/jira/browse/HDFS-6150
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Suresh Srinivas
>         Attachments: HDFS-6150.patch
>
>
> Inode information and path information are missing in the logs and exceptions. Adding this will help debug multi threading issues related to using incode INode ID information.



--
This message was sent by Atlassian JIRA
(v6.2#6252)