[DISCUSS]Sonar Check for the PR from non-committer

[Haonan Hou <hh...@outlook.com>]

Hi,

When I review the PR[1] that fixed a lot of code smells, I find out I have to pull this PR to my local machine and re-push it as a new branch in Apache repository to invoke the SonarCloud code analysis [2]. The sonarCloud cannot check the PR from other repository directly.

I would like to discuss if we need to do this for every PR from non-committers. Or does anyone have a better idea about the sonar check?

[1] https://github.com/apache/iotdb/pull/1750
[2] https://github.com/apache/iotdb/pull/1750/checks?check_run_id=1245566911

Thanks,
Haonan Hou

Re: [DISCUSS]Sonar Check for the PR from non-committer

[Xiangdong Huang <sa...@gmail.com>]

Hi,

I remember it is due to 'fork=false' in .travis.yml. You can remove it and
have a try.

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Haonan Hou <hh...@outlook.com> 于2020年10月13日周二 下午4:05写道：

> Hi,
>
> When I review the PR[1] that fixed a lot of code smells, I find out I have
> to pull this PR to my local machine and re-push it as a new branch in
> Apache repository to invoke the SonarCloud code analysis [2]. The
> sonarCloud cannot check the PR from other repository directly.
>
> I would like to discuss if we need to do this for every PR from
> non-committers. Or does anyone have a better idea about the sonar check?
>
> [1] https://github.com/apache/iotdb/pull/1750
> [2]
> https://github.com/apache/iotdb/pull/1750/checks?check_run_id=1245566911
>
> Thanks,
> Haonan Hou
>