[jira] [Commented] (OFBIZ-5565) FinAccountHelper.getFinAccountFromCode() no longer returns financial account

["Jacopo Cappellato (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942860#comment-13942860 ] 

Jacopo Cappellato commented on OFBIZ-5565:
------------------------------------------

Thanks Vyom for the detailed bug report and for the unit test (that should be committed with the fix when we will have one).
Here I am providing a quick reference with the steps to run your test and start playing with the code; hopefully others will help to create a fix and attach it here:

* apply the patch (it is a git patch but it is very simple and can be manually applied)
* build the system:
{code}
./ant clean-all load-demo
{code}
* run the tests:
{code}
./ant run-test-suite -Dtest.component=accounting -Dtest.suiteName=accountingtests
{code}

You should get the following result:
{code}
[JUNIT] Pass: false | # Tests: 12 | # Failed: 1 # Errors: 0
[JUNIT] ----------------------------- ERRORS ----------------------------- [JUNIT]
 None
[JUNIT] ------------------------------------------------------------------ [JUNIT]
[JUNIT] ---------------------------- FAILURES ---------------------------- [JUNIT]
 --> testGetFinAccountFromFinAccountCode(org.ofbiz.accounting.test.FinAccountTests): null
{code}



> FinAccountHelper.getFinAccountFromCode() no longer returns financial account
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-5565
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5565
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting, order
>    Affects Versions: SVN trunk, Release Branch 13.07
>         Environment: Primarily tested on Ubuntu, but affects all OS.
>            Reporter: Vyom Jain
>             Fix For: SVN trunk, Release Branch 13.07
>
>         Attachments: OFBIZ-5565.patch
>
>
> FinAccountHelper.getFinAccountFromCode() in trunk as well as in some of the released versions is no longer able to fetch the Financial Account ID. 
> So all features dependent on this method would no longer work (an example being paying by gift card during order entry process).
> Per my research, this stopped working method post some changes related to how data is encrypted (two strings will not have similar encrypted string).
> I had tried this on a fresh SVN trunk checkout with absolutely no changes (had been using Derby database).
> Furthermore, the ant target gen-kek references old jars and that needs fixing as well.
> Steps to test - 
> 1. Create a new Financial account (gift certificate) for DemoCustomer - https://demo-trunk.ofbiz.apache.org/accounting/control/FindFinAccount?ownerPartyId=DemoCustomer and deposit some funds into it.
> 2. Create an order for DemoCustomer from the Order Manager application.
> 3. Use "Quick Finalize Order", try paying by the gift card created in step #1.
> Observations - 
> 1. Returns an error "This gift card does not exist"
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)