[jira] [Commented] (HBASE-28705) BackupLogCleaner cleans required WALs when using multiple backuproots

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-28705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885137#comment-17885137 ] 

Hudson commented on HBASE-28705:
--------------------------------

Results for branch branch-3
	[build #297 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/297/]: (/) *{color:green}+1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/297/General_20Nightly_20Build_20Report/]








(/) {color:green}+1 jdk17 hadoop3 checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/297/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> BackupLogCleaner cleans required WALs when using multiple backuproots
> ---------------------------------------------------------------------
>
>                 Key: HBASE-28705
>                 URL: https://issues.apache.org/jira/browse/HBASE-28705
>             Project: HBase
>          Issue Type: Bug
>          Components: backup&restore
>    Affects Versions: 2.6.0, 3.0.0
>            Reporter: Dieter De Paepe
>            Assignee: Dieter De Paepe
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 2.7.0, 3.0.0-beta-2, 2.6.1
>
>
> The BackupLogCleaner is responsible for avoiding the deletion of WAL/logs that still need to be included in a future backup.
> The logic to decide which files can be deleted does not work correctly when multiple backup roots are used. Each backup root has a different chain of backups (full, incremental1, incremental2, ...). So, if any chain requires a log, it should be preserved. This is not the case.
> The result is that logs could be incorrectly deleted, resulting in data loss in backups.
> PR incoming with test & fix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)