[jira] [Comment Edited] (MAPREDUCE-6584) mapred-default.xml has spaces and tabs

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066703#comment-15066703 ] 

Allen Wittenauer edited comment on MAPREDUCE-6584 at 12/21/15 5:02 PM:
-----------------------------------------------------------------------

This falls into the same category as the ASF license warnings after the unit test.  Hadoop's build is buggy.  In this case, not only are there whitespace issues but I suspect mapred-default.xml isn't getting removed from the site directories after a mvn clean [1].  Yetus has found that corner case where it is buggy.  If Hadoop was building things correctly, then this becomes a non-issue.

EDIT: 

[1] - Looking at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6222/artifact/patchprocess/gitdiffcontent.txt, that's exactly what's happening. mvn clean in mapreduce doesn't clean out the directories properly so the patch "inherits" any left over bits.


was (Author: aw):
This falls into the same category as the ASF license warnings after the unit test.  Hadoop's build is buggy.  In this case, not only are there whitespace issues but I suspect mapred-default.xml isn't getting removed from the site directories after a mvn clean.  Yetus has found that corner case where it is buggy.  If Hadoop was building things correctly, then this becomes a non-issue.

> mapred-default.xml has spaces and tabs
> --------------------------------------
>
>                 Key: MAPREDUCE-6584
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6584
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: build
>            Reporter: Akira AJISAKA
>
> In MAPREDUCE-6583, test-patch reported that mapred-default.xml has many trailing whitespaces.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)