You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/05 18:20:37 UTC
[GitHub] [netbeans] tbw777 opened a new pull request, #5214: Removed redundant static modifier for interface
tbw777 opened a new pull request, #5214:
URL: https://github.com/apache/netbeans/pull/5214
No needed to use static modifier for interfaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5214: Removed redundant static modifier for interface
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5214:
URL: https://github.com/apache/netbeans/pull/5214#issuecomment-1407467406
how much disk space does this save?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5214: Removed redundant static modifier for interface
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5214:
URL: https://github.com/apache/netbeans/pull/5214#issuecomment-1416541814
@vieiro I would like to close this one. I don't see the point of this. I hope you haven't started reviewing yet :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5214: Removed redundant static modifier for interface
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5214:
URL: https://github.com/apache/netbeans/pull/5214#issuecomment-1407559383
i mean source code of course )) Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro closed pull request #5214: Removed redundant static modifier for interface
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro closed pull request #5214: Removed redundant static modifier for interface
URL: https://github.com/apache/netbeans/pull/5214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5214: Removed redundant static modifier for interface
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5214:
URL: https://github.com/apache/netbeans/pull/5214#issuecomment-1407440088
Updated with changes from #5215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5214: Removed redundant static modifier for interface
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5214:
URL: https://github.com/apache/netbeans/pull/5214#issuecomment-1407477093
@mbien
Less then sector size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5214: Removed redundant static modifier for interface
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5214:
URL: https://github.com/apache/netbeans/pull/5214#issuecomment-1407440313
>Can you elaborate on the benefit of this PR to the NetBeans project?
The project will take up less disk space, less time to compile, less time to index in the ide, less distraction for the developer with the PR installed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5214: Removed redundant static modifier for interface
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5214:
URL: https://github.com/apache/netbeans/pull/5214#issuecomment-1416714090
@mbien +1 in closing: can't see any advantage in the PR. Compiling >500k LOC because of this is a waste of resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5214: Removed redundant static modifier for interface
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5214:
URL: https://github.com/apache/netbeans/pull/5214#issuecomment-1407479147
Hi @tbw777 ,
The fact is that the Java compiler ignores "static" in inner interfaces and enums. The bytecode is exactly the same. You can test this yourself compiling these simple classes:
```java
package a.b.c;
public class A {
public static interface AA {}
public static enum AAA {}
}
```
and
```java
package a.b.c;
public class B {
public interface BB {}
public enum BBB {}
}
```
If you compile these classes with `javac` you'll see that the generated `A.class` and `B.class` have exactly the same size.
This does not affect performance, either. Since the generated bytecode is exactly the same the performance will be the same.
The fact is that this PR makes no difference to NetBeans. There will be no difference in performance, network consumption, etc.
We may approve it, since it does some cleaning of the source code, but I will have to review those 729 files, one by one, that you have changed, to make sure all your changes are correct. This is going to take some time to me, because I don't work for this. Maybe one week or two.
During these two weeks I won't be able to do anything else, I'm afraid.
Maybe next time you send a PR you can ask in the mailing list if the PR is worth the effort reviewing, because we would prefer adding new features to NetBeans instead of reviewing PRs that make no difference in performance. What say?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists