You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "javanna (via GitHub)" <gi...@apache.org> on 2023/05/03 08:10:27 UTC
[GitHub] [lucene] javanna opened a new pull request, #12260: Fix SynonymQuery equals implementation
javanna opened a new pull request, #12260:
URL: https://github.com/apache/lucene/pull/12260
The `term` member of `TermAndBoost` used to be a `Term` instance and became a `BytesRef` with #11941, which means its `equals` impl won't take the field name into account. The `SynonymQuery` equals impl needs to be updated accordingly to take the field into account as well, otherwise synonym queries with same term and boost across different fields are equal which is a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix SynonymQuery equals implementation [lucene]
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on PR #12260:
URL: https://github.com/apache/lucene/pull/12260#issuecomment-1765741713
Hi, @mingshl
I'm able to cherrypick this fix into branch_9_4, but I'm not sure if there'll be release 9.4.2 ever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix SynonymQuery equals implementation [lucene]
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna commented on PR #12260:
URL: https://github.com/apache/lucene/pull/12260#issuecomment-1768403778
> I'm able to cherrypick this fix into branch_9_4, but I'm not sure if there'll be release 9.4.2 ever.
Indeed, there won't be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix SynonymQuery equals implementation [lucene]
Posted by "mingshl (via GitHub)" <gi...@apache.org>.
mingshl commented on PR #12260:
URL: https://github.com/apache/lucene/pull/12260#issuecomment-1766881156
Thank you! @mkhludnev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] javanna commented on pull request #12260: Fix SynonymQuery equals implementation
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna commented on PR #12260:
URL: https://github.com/apache/lucene/pull/12260#issuecomment-1532715530
> Do you think it's worth me re-spinning the 9.6 release to get this in?
I am not super familiar with what is generally worth a respin, I do agree that this is quite a bad bug, and it'd be a shame to wait releasing the fix for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] javanna merged pull request #12260: Fix SynonymQuery equals implementation
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna merged PR #12260:
URL: https://github.com/apache/lucene/pull/12260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix SynonymQuery equals implementation [lucene]
Posted by "mingshl (via GitHub)" <gi...@apache.org>.
mingshl commented on PR #12260:
URL: https://github.com/apache/lucene/pull/12260#issuecomment-1765091198
@romseygeek @mkhludnev, this bug was introduced since 9.4 version, can this PR be back-ported to 9.4.2 to fix the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org