You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Lucian Adrian Grijincu <lu...@gmail.com> on 2007/10/28 23:13:39 UTC

[PATCH] apr_dir_remove_recursive

Attached a patch that adds apr_dir_remove_recursive for trunk/

I've only tested this on Ubuntu 7.10.
It ads a new "fileutil.c" file in unix/

Someone should test this, I currently cannot (OS not available):
1) I've also added a #SOURCE to apr.dsp and libapr.dsp for windows
    build referencing the unix file.
2) Added a reference in NWGNUmakefile too.
3) For os2 there's a new file fileutil.c that #includes the unix/ equivalent.

There's a testcase too.

BTW, I wanted to add a test for deleting symlinks, but there is no APR
API to create a symlink and on another thread on this list someone
expressed their opposition for platform specific tests. What should be
done in this case?

--
Lucian

Re: [PATCH] apr_dir_remove_recursive

Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
How about this?
It got some review in the past[1]
is it fit for inclusion?

[1] http://www.mail-archive.com/dev@apr.apache.org/msg17650.html

On Mon, Oct 29, 2007 at 1:13 AM, Lucian Adrian Grijincu
<lu...@gmail.com> wrote:
> Attached a patch that adds apr_dir_remove_recursive for trunk/
>
>  I've only tested this on Ubuntu 7.10.
>  It ads a new "fileutil.c" file in unix/
>
>  Someone should test this, I currently cannot (OS not available):
>  1) I've also added a #SOURCE to apr.dsp and libapr.dsp for windows
>     build referencing the unix file.
>  2) Added a reference in NWGNUmakefile too.
>  3) For os2 there's a new file fileutil.c that #includes the unix/ equivalent.
>
>  There's a testcase too.
>
>  BTW, I wanted to add a test for deleting symlinks, but there is no APR
>  API to create a symlink and on another thread on this list someone
>  expressed their opposition for platform specific tests. What should be
>  done in this case?



-- 
Lucian