You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "jstastny-cz (via GitHub)" <gi...@apache.org> on 2026/04/23 10:45:01 UTC
[PR] incubator-kie-issues#2286: isolate and test data-index storage modules [incubator-kie-kogito-apps]
jstastny-cz opened a new pull request, #2325:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2325
Closes apache/incubator-kie-issues#2286
Extending test coverage for Spring Boot Data Index Storage JPA module by replicating the existing coverage from Quarkus variant.
To achieve that, existing modules which were closely aligned with Quarkus (especially annotations) needed to be refactored:
* quarkus-specific annotations, class references (e.g. `Instance<>`), tests and test dependencies moved out from `data-index-storage-jpa-common` and `data-index-storage-jpa` to newly added `data-index-storage-jpa-quarkus` module.
* `data-index-storage-jpa-common` is still dependency of both `data-index-storage-jpa` and `data-index-storage-postgresql`, but does NOT provide any quarkus annotated beans.
* `data-index-storage-jpa-quarkus` and `data-index-storage-jpa-springboot` now
* use `data-index-storage-jpa` as dependency (still without framework specific beans).
* take care of defining framework-specific beans by constructor injection in framework-specific classes, but instantiating the shared classes using regular constructor `super(...)`
* contain equivalent test coverage by extending abstract test classes and providing framework-specific configuration and annotations.
* `data-index-storage-jpa` and `data-index-storage-postgresql` need both quarkus-specific beans, so there's some level of duplication, but it's a trivial class inheritance, injection and invocation of super-class constructor with injected values.
* The shared components and tests still use classes and annotations supported by both Quarkus and Spring Boot, e.g. `@Transactional`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] incubator-kie-issues#2286: isolate and test data-index storage modules [incubator-kie-kogito-apps]
Posted by "martinweiler (via GitHub)" <gi...@apache.org>.
martinweiler merged PR #2325:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] incubator-kie-issues#2286: isolate and test data-index storage modules [incubator-kie-kogito-apps]
Posted by "jstastny-cz (via GitHub)" <gi...@apache.org>.
jstastny-cz commented on PR #2325:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2325#issuecomment-4311941464
There are still the abstract tests using Inject and ApplicationScoped annotations, need to refactor them too to pass instances via constructor from the framework-specific test subclasses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org