[GitHub] stu1130 commented on a change in pull request #13357: Add imresize and copyMakeBorder to mx.image

[GitBox <gi...@apache.org>]

stu1130 commented on a change in pull request #13357: Add imresize and copyMakeBorder to mx.image
URL: https://github.com/apache/incubator-mxnet/pull/13357#discussion_r235835214
 
 

 ##########
 File path: tests/python/unittest/test_image.py
 ##########
 @@ -139,6 +140,26 @@ def test_resize_short(self):
                     mx_resized = mx.image.resize_short(mx_img, new_size, interp)
                     assert_almost_equal(mx_resized.asnumpy()[:, :, (2, 1, 0)], cv_resized, atol=3)
 
+    @with_seed()
+    def test_imresize(self):
+        try:
+            import cv2
+        except ImportError:
+            raise unittest.SkipTest("Unable to import cv2")
+        for img in TestImage.IMAGES:
+            cv_img = cv2.imread(img)
+            mx_img = mx.nd.array(cv_img[:, :, (2, 1, 0)])
+            for _ in range(3):
 
 Review comment:
   why test the same things three times here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services