[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4648: [KYUUBI #4522][Bug] The use:catalog and use:database execution order seems not guaranteed

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #4648:
URL: https://github.com/apache/kyuubi/pull/4648#discussion_r1155462291


##########
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/session/FlinkSessionImpl.scala:
##########
@@ -57,16 +57,20 @@ class FlinkSessionImpl(
 
   override def open(): Unit = {
     executor.openSession(handle.identifier.toString)
-    normalizedConf.foreach {
-      case ("use:catalog", catalog) =>
+    normalizedConf.get("use:catalog") match {

Review Comment:
   How about
   ```
       val (useCatalogAndDatabaseConf, otherConf) = normalizedConf.partition { case (k, _) =>
         !Set("use:catalog", "use:database").contains(k)
       }
   ```
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org