[jira] [Commented] (KAFKA-3881) Remove the replacing logic from "." to "_" in Fetcher

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044383#comment-17044383 ] 

ASF GitHub Bot commented on KAFKA-3881:
---------------------------------------

tombentley commented on pull request #3407: KAFKA-3881: Remove the replacing logic from "." to "_" in Fetcher
URL: https://github.com/apache/kafka/pull/3407
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove the replacing logic from "." to "_" in Fetcher
> -----------------------------------------------------
>
>                 Key: KAFKA-3881
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3881
>             Project: Kafka
>          Issue Type: Bug
>          Components: consumer, metrics
>            Reporter: Guozhang Wang
>            Assignee: Tom Bentley
>            Priority: Major
>              Labels: newbie, patch-available
>
> The logic of replacing "." to "_" in metrics names / tags was originally introduced in the core package's metrics since Graphite treats "." as hierarchy separators (see KAFKA-1902); for the client metrics, it is supposed that the GraphiteReported should take care of this itself rather than letting Kafka metrics to special handle for it. In addition, right now only consumer Fetcher had replace, but producer Sender does not have it actually.
> So we should consider removing this logic in the consumer Fetcher's metrics package. NOTE that this is a public API backward incompatible change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)