You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by "Chesnay Schepler (Jira)" <ji...@apache.org> on 2021/11/24 12:09:00 UTC

[jira] [Created] (FLINK-25043) Allow calls to public @VisibleForTesting from the same package

Chesnay Schepler created FLINK-25043:
----------------------------------------

             Summary: Allow calls to public @VisibleForTesting from the same package
                 Key: FLINK-25043
                 URL: https://issues.apache.org/jira/browse/FLINK-25043
             Project: Flink
          Issue Type: Improvement
          Components: Tests
            Reporter: Chesnay Schepler
             Fix For: 1.15.0


Consider a class having some package-private method that is used by other classes in said package.

If this method is then needed from outside the package, and thus made public and annotated with VisibleForTesting, then the architecture tests currently flag the original usage as well.

We could think about allowing package-private access if the method is public.

On the other hand, if the method was originally annotated with VisibleForTesting, then marking it as public would remove a violation, which would be incorrect.

Maybe we need to extend our VisibleForTesting annotation to provide this information.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)