You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/07/03 17:03:10 UTC
[GitHub] [submarine] kevin85421 opened a new pull request #638: SUBMARINE-894. Reduce the image size of submarine-operator
kevin85421 opened a new pull request #638:
URL: https://github.com/apache/submarine/pull/638
### What is this PR for?
The original submarine-operator docker image is 906 MB, and thus it will be very time-consuming for users who want to pull the image from DockerHub. Hence, a light submarine-operator image is needed. In addition, although the original Docker image is large, it is suitable for development, so we will not remove the Dockerfile.
In addition, the new docker image will replace the deprecated operator image (submarine-cloud).
### What type of PR is it?
[Improvement]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-894
### How should this be tested?
* Github action (deploy-image)
### Screenshots (if appropriate)
<img width="1440" alt="截圖 2021-07-03 下午9 46 29" src="https://user-images.githubusercontent.com/20109646/124361792-7f447d00-dc63-11eb-9c18-51601b3d5771.png">
<img width="916" alt="截圖 2021-07-03 下午9 47 10" src="https://user-images.githubusercontent.com/20109646/124361797-87042180-dc63-11eb-9620-4619f73d7ff7.png">
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] KUAN-HSUN-LI commented on a change in pull request #638: SUBMARINE-894. Reduce the image size of submarine-operator
Posted by GitBox <gi...@apache.org>.
KUAN-HSUN-LI commented on a change in pull request #638:
URL: https://github.com/apache/submarine/pull/638#discussion_r663439030
##########
File path: submarine-cloud-v2/Makefile
##########
@@ -30,8 +30,9 @@ api:
.PHONY: image
image: charts
+ eval $(minikube docker-env)
GOOS=linux go build -o submarine-operator
- docker build -t submarine-operator .
+ docker build -t submarine-operator -f dev.Dockerfile .
Review comment:
why specify a non-existing file here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kevin85421 commented on pull request #638: SUBMARINE-894. Reduce the image size of submarine-operator
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on pull request #638:
URL: https://github.com/apache/submarine/pull/638#issuecomment-873503518
@KUAN-HSUN-LI Can you help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #638: SUBMARINE-894. Reduce the image size of submarine-operator
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #638:
URL: https://github.com/apache/submarine/pull/638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org