You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2022/10/21 16:40:58 UTC

[camel] branch main updated: (chores) camel-catalog-maven: reduce method complexity (#8608)

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/main by this push:
     new 40d826e2580 (chores) camel-catalog-maven: reduce method complexity (#8608)
40d826e2580 is described below

commit 40d826e25808f3251eb0ad0e1dd45cd827028ae1
Author: Otavio Rodolfo Piske <or...@users.noreply.github.com>
AuthorDate: Fri Oct 21 18:40:52 2022 +0200

    (chores) camel-catalog-maven: reduce method complexity (#8608)
---
 .../maven/DefaultMavenArtifactProvider.java        | 28 ++++++++++++----------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/catalog/camel-catalog-maven/src/main/java/org/apache/camel/catalog/maven/DefaultMavenArtifactProvider.java b/catalog/camel-catalog-maven/src/main/java/org/apache/camel/catalog/maven/DefaultMavenArtifactProvider.java
index 495770d0c37..97e41203e23 100644
--- a/catalog/camel-catalog-maven/src/main/java/org/apache/camel/catalog/maven/DefaultMavenArtifactProvider.java
+++ b/catalog/camel-catalog-maven/src/main/java/org/apache/camel/catalog/maven/DefaultMavenArtifactProvider.java
@@ -117,21 +117,25 @@ public class DefaultMavenArtifactProvider implements MavenArtifactProvider {
             String[] part = components.split("\\s");
             for (String scheme : part) {
                 if (!camelCatalog.findComponentNames().contains(scheme)) {
-                    // find the class name
-                    String javaType = extractComponentJavaType(log, classLoader, scheme);
-                    if (javaType != null) {
-                        String json = loadComponentJSonSchema(log, classLoader, scheme);
-                        if (json != null) {
-                            if (log) {
-                                LOGGER.info("Adding component: {}", scheme);
-                            }
-                            camelCatalog.addComponent(scheme, javaType, json);
-                            names.add(scheme);
-                        }
-                    }
+                    findClassName(camelCatalog, classLoader, names, scheme);
                 }
             }
         }
     }
 
+    private void findClassName(CamelCatalog camelCatalog, ClassLoader classLoader, Set<String> names, String scheme) {
+        // find the class name
+        String javaType = extractComponentJavaType(log, classLoader, scheme);
+        if (javaType != null) {
+            String json = loadComponentJSonSchema(log, classLoader, scheme);
+            if (json != null) {
+                if (log) {
+                    LOGGER.info("Adding component: {}", scheme);
+                }
+                camelCatalog.addComponent(scheme, javaType, json);
+                names.add(scheme);
+            }
+        }
+    }
+
 }