[GitHub] [arrow-rs] alamb commented on pull request #810: Validate arguments to ArrayData::new and null bit buffer and buffers

[GitBox <gi...@apache.org>]

alamb commented on pull request #810:
URL: https://github.com/apache/arrow-rs/pull/810#issuecomment-961355206


   > I think this looks good. Might be worthwhile to convert some of the current new_unchecked usages to try_new to increase coverage.
   
   At the moment, almost all of the tests in arrow use `ArrayData::try_new(...).unwrap()` so there is pretty good coverage of this code already (I found several bugs this way :) )
   
   The remaining uses of `new_unchecked()` are either  in compute kernels where performance seems to be critical or in tests which are explicitly checking array construction validation. 
   
   What I plan as part of implementing `validate_full()` is to remove all array specific type checks and the tests to use `ArrayData::try_new()`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org