You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "weihubeats (via GitHub)" <gi...@apache.org> on 2024/04/29 09:58:26 UTC
[PR] Remove useless heartbeat success log prints [rocketmq-clients]
weihubeats opened a new pull request, #740:
URL: https://github.com/apache/rocketmq-clients/pull/740
https://github.com/apache/rocketmq-clients/issues/739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove useless heartbeat success log prints [rocketmq-clients]
Posted by "weihubeats (via GitHub)" <gi...@apache.org>.
weihubeats commented on code in PR #740:
URL: https://github.com/apache/rocketmq-clients/pull/740#discussion_r1582823028
##########
golang/client.go:
##########
@@ -436,7 +436,6 @@ func (cli *defaultClient) doHeartbeat(target string, request *v2.HeartbeatReques
Message: resp.GetStatus().GetMessage(),
}
}
- cli.log.Infof("send heartbeat successfully, endpoints=%v", endpoints)
Review Comment:
Consider changing to debug level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove useless heartbeat success log prints [rocketmq-clients]
Posted by "weihubeats (via GitHub)" <gi...@apache.org>.
weihubeats commented on PR #740:
URL: https://github.com/apache/rocketmq-clients/pull/740#issuecomment-2099677043
@lizhanhui Is there anything else wrong with this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove useless heartbeat success log prints [rocketmq-clients]
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui merged PR #740:
URL: https://github.com/apache/rocketmq-clients/pull/740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove useless heartbeat success log prints [rocketmq-clients]
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui commented on PR #740:
URL: https://github.com/apache/rocketmq-clients/pull/740#issuecomment-2100192370
> @lizhanhui Is there anything else wrong with this pr?
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove useless heartbeat success log prints [rocketmq-clients]
Posted by "weihubeats (via GitHub)" <gi...@apache.org>.
weihubeats commented on PR #740:
URL: https://github.com/apache/rocketmq-clients/pull/740#issuecomment-2100207461
So this mr can merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove useless heartbeat success log prints [rocketmq-clients]
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui commented on code in PR #740:
URL: https://github.com/apache/rocketmq-clients/pull/740#discussion_r1582818675
##########
golang/client.go:
##########
@@ -436,7 +436,6 @@ func (cli *defaultClient) doHeartbeat(target string, request *v2.HeartbeatReques
Message: resp.GetStatus().GetMessage(),
}
}
- cli.log.Infof("send heartbeat successfully, endpoints=%v", endpoints)
Review Comment:
Change log level to debug instead of removal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove useless heartbeat success log prints [rocketmq-clients]
Posted by "weihubeats (via GitHub)" <gi...@apache.org>.
weihubeats commented on PR #740:
URL: https://github.com/apache/rocketmq-clients/pull/740#issuecomment-2123948927
@lizhanhui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org