You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/08/29 05:59:49 UTC
[GitHub] [incubator-opendal] Xuanwo opened a new issue, #2965: tests: Replace existing binary test file with readable content
Xuanwo opened a new issue, #2965:
URL: https://github.com/apache/incubator-opendal/issues/2965
As mentioned in https://lists.apache.org/thread/z10fb1y93oq4xf3jqd1tzgoczknd9cv3
Some test files in OpenDAL are binary which can't be reviewed. It's better for us to replace them with readable content:
- https://github.com/apache/incubator-opendal/blob/main/core/tests/data/normal_file
- https://github.com/apache/incubator-opendal/blob/main/core/tests/data/special_file%20%20!%40%23%24%25%5E%26()_%2B-%3D%3B'%2C
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] gongyisheng commented on issue #2965: tests: Replace existing binary test file with readable content
Posted by "gongyisheng (via GitHub)" <gi...@apache.org>.
gongyisheng commented on issue #2965:
URL: https://github.com/apache/incubator-opendal/issues/2965#issuecomment-1699628802
Can I have a try on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2965: tests: Replace existing binary test file with readable content
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2965:
URL: https://github.com/apache/incubator-opendal/issues/2965#issuecomment-1696820435
Please note the tests should also be updated.
The content could be OpenDAL VISION: `OpenDAL: access data freely.` x 1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2965: tests: Replace existing binary test file with readable content
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2965:
URL: https://github.com/apache/incubator-opendal/issues/2965#issuecomment-1704550844
Fixed by https://github.com/apache/incubator-opendal/pull/3003, thank you, @gongyisheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo closed issue #2965: tests: Replace existing binary test file with readable content
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #2965: tests: Replace existing binary test file with readable content
URL: https://github.com/apache/incubator-opendal/issues/2965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] gongyisheng commented on issue #2965: tests: Replace existing binary test file with readable content
Posted by "gongyisheng (via GitHub)" <gi...@apache.org>.
gongyisheng commented on issue #2965:
URL: https://github.com/apache/incubator-opendal/issues/2965#issuecomment-1703787984
The python binding test failed: https://github.com/apache/incubator-opendal/actions/runs/6057666089/job/16439057973, but it looks not related to the test files (`normal_file`, `special_file`) I changed in PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2965: tests: Replace existing binary test file with readable content
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2965:
URL: https://github.com/apache/incubator-opendal/issues/2965#issuecomment-1700162398
> Can I have a try on this issue?
Thanks a lot! Have fun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #2965: tests: Replace existing binary test file with readable content
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2965:
URL: https://github.com/apache/incubator-opendal/issues/2965#issuecomment-1703830652
> The python binding test failed: https://github.com/apache/incubator-opendal/actions/runs/6057666089/job/16439057973, but it looks not related to the test files (`normal_file`, `special_file`) I changed in PR.
>
>
>
> `Fatal Python error: PyGILState_Release: thread state 0x7f2950006210 must be current when releasing`
>
>
Yep. There are some flaky in our python binding test that not addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org