[jira] [Comment Edited] (BEAM-230) Remove WindowedValue#valueInEmptyWindows

["Kenneth Knowles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016574#comment-16016574 ] 

Kenneth Knowles edited comment on BEAM-230 at 5/18/17 10:41 PM:
----------------------------------------------------------------

This is not subject to backwards compatibility - just some runners-core-bound stuff in util. It should still be removed, as it is a bit dangerous and semantically hazy.


was (Author: kenn):
This is not subject to backwards compatibility. It should still be removed, as it is a bit dangerous and semantically hazy.

> Remove WindowedValue#valueInEmptyWindows
> ----------------------------------------
>
>                 Key: BEAM-230
>                 URL: https://issues.apache.org/jira/browse/BEAM-230
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>             Fix For: Not applicable
>
>
> A WindowedValue in no windows does not exist, and can be dropped by a runner at any time.
> We should also assert that any collection of windows is nonempty when creating a new WindowedValue. If a user wants to drop an element, they should explicitly filter it out rather than expecting it to be dropped by the runner.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)