You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by "IsmoLeszczynski (via GitHub)" <gi...@apache.org> on 2024/04/15 18:53:56 UTC

[PR] fix(plc4j/ads): Fixed connection hang on exception

IsmoLeszczynski opened a new pull request, #1530:
URL: https://github.com/apache/plc4x/pull/1530

   When getting a new ADS connection, the connection could hang indefinitely if the final symbol reading future threw an exception, causing only an error log to be written, leaving the context without a completion call. This situation happened when everything aside from the Target AMS Port were correct, the connection retrieval would never return due to this error.
   
   Since the other exceptions in previous steps terminated the connection, I determined that this should also simply fail the connection attempt.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(plc4j/ads): Fixed connection hang on exception

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz merged PR #1530:
URL: https://github.com/apache/plc4x/pull/1530


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org