You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/15 11:53:12 UTC
[GitHub] [airflow] MazrimT opened a new pull request, #24468: Added as_dict and custom query to BigQueryGetDataOperator
MazrimT opened a new pull request, #24468:
URL: https://github.com/apache/airflow/pull/24468
- added as_dict flag to return data as list of dicts
- added functionality to input a custom query that will run be executed as a cursor.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #24460
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24468: Add as_dict and custom query to BigQueryGetDataOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24468:
URL: https://github.com/apache/airflow/pull/24468#issuecomment-1169596566
Needs fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24468: Add as_dict and custom query to BigQueryGetDataOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24468:
URL: https://github.com/apache/airflow/pull/24468#issuecomment-1159813165
cc: @lwyszomi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24468: Add as_dict and custom query to BigQueryGetDataOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24468:
URL: https://github.com/apache/airflow/pull/24468#issuecomment-1226621899
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on a diff in pull request #24468: Add as_dict and custom query to BigQueryGetDataOperator
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on code in PR #24468:
URL: https://github.com/apache/airflow/pull/24468#discussion_r901361071
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -425,27 +437,45 @@ def execute(self, context: 'Context') -> list:
gcp_conn_id=self.gcp_conn_id,
delegate_to=self.delegate_to,
impersonation_chain=self.impersonation_chain,
+ location=self.location,
+ use_legacy_sql=self.use_legacy_sql
)
- if not self.selected_fields:
- schema: Dict[str, list] = hook.get_schema(
+ if not self.query:
+ if not self.selected_fields:
+ schema: Dict[str, list] = hook.get_schema(
+ dataset_id=self.dataset_id,
+ table_id=self.table_id,
+ )
+ if "fields" in schema:
+ self.selected_fields = ','.join([field["name"] for field in schema["fields"]])
+
+ rows = hook.list_rows(
dataset_id=self.dataset_id,
table_id=self.table_id,
+ max_results=self.max_results,
+ selected_fields=self.selected_fields
)
- if "fields" in schema:
- self.selected_fields = ','.join([field["name"] for field in schema["fields"]])
- rows = hook.list_rows(
- dataset_id=self.dataset_id,
- table_id=self.table_id,
- max_results=self.max_results,
- selected_fields=self.selected_fields,
- location=self.location,
- )
+ if self.as_dict:
+ table_data = [json.dumps(dict(zip(self.selected_fields, row))).encode('utf-8') for row in rows]
+ else:
+ table_data = [row.values() for row in rows]
+
+ else:
+
+ conn = hook.get_conn()
+ cursor = conn.cursor()
+ cursor.execute(self.query)
+ #if self.as_dict:
+ # table_data = [json.dumps(dict(zip(self.selected_fields,row))).encode('utf-8') for row in cursor.fetchmany(self.max_results)]
+ # this doesn't work, we don't know the field names, however the base function "next" on row 2657 in the BigQueryHook collects the field names and then discards them.
+ table_data = [row for row in cursor.fetchmany(self.max_results)]
+
+ cursor.close()
Review Comment:
Maybe we should consider to extract this to the new method inside the hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24468: Added as_dict and custom query to BigQueryGetDataOperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #24468:
URL: https://github.com/apache/airflow/pull/24468#issuecomment-1156376446
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #24468: Add as_dict and custom query to BigQueryGetDataOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #24468: Add as_dict and custom query to BigQueryGetDataOperator
URL: https://github.com/apache/airflow/pull/24468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org