You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by maskit <gi...@git.apache.org> on 2015/12/19 17:21:59 UTC
[GitHub] trafficserver pull request: TS-3967: Set stream state to close aft...
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/389
TS-3967: Set stream state to close after a RST_STEAM has been sent
https://issues.apache.org/jira/browse/TS-3967
The original patches are on the JIRA ticket. I updated the patches to resolve conflicts, and made little changes to satisfy h2spec tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maskit/trafficserver ts-3967
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/389.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #389
----
commit 54f4907c0efefa943c4ea9c332cda34dd1a29426
Author: Masakazu Kitajo <ma...@apache.org>
Date: 2015-12-19T12:52:05Z
TS-3967: Set stream state to close after a RST_STEAM has been sent
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3967: Set stream state to close aft...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/389#discussion_r48112070
--- Diff: proxy/http2/HTTP2.cc ---
@@ -665,11 +666,19 @@ http2_decode_header_blocks(HTTPHdr *hdr, const uint8_t *buf_start, const uint8_t
}
}
+ // turn on that we have a trailer header
+ char trailer_name[] = "trailer";
--- End diff --
`const` ? Should be defined in HTTP2.h ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3967: Set stream state to close aft...
Posted by maskit <gi...@git.apache.org>.
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/389#discussion_r48120169
--- Diff: proxy/http2/HTTP2.cc ---
@@ -665,11 +666,19 @@ http2_decode_header_blocks(HTTPHdr *hdr, const uint8_t *buf_start, const uint8_t
}
}
+ // turn on that we have a trailer header
+ char trailer_name[] = "trailer";
+ if (name_len == (sizeof(trailer_name) - 1) && strncmp(name, trailer_name, sizeof(trailer_name) - 1) == 0) {
+ trailing_header = true;
--- End diff --
`trailing_header` is for caller. It suggests existence of trailing header to outside of this function.
`is_trailing_header` is for callee. It suggests that this block is trailing header to skip the pseudo header checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3967: Set stream state to close aft...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/389#discussion_r48111940
--- Diff: proxy/http2/HTTP2.cc ---
@@ -665,11 +666,19 @@ http2_decode_header_blocks(HTTPHdr *hdr, const uint8_t *buf_start, const uint8_t
}
}
+ // turn on that we have a trailer header
+ char trailer_name[] = "trailer";
+ if (name_len == (sizeof(trailer_name) - 1) && strncmp(name, trailer_name, sizeof(trailer_name) - 1) == 0) {
+ trailing_header = true;
--- End diff --
`is_trailing_header` ? It looks like `trailing_header` is not used in below code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3967: Set stream state to close aft...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/389#discussion_r48111868
--- Diff: proxy/http2/RegressionHPACK.cc ---
@@ -441,6 +441,7 @@ REGRESSION_TEST(HPACK_Decode)(RegressionTest *t, int, int *pstatus)
box = REGRESSION_TEST_PASSED;
Http2DynamicTable dynamic_table;
+ bool trailing_header;
--- End diff --
Should be initialised?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3967: Set stream state to close aft...
Posted by maskit <gi...@git.apache.org>.
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/389#issuecomment-170236549
rebased to follow the changes in master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3967: Set stream state to close aft...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/389
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3967: Set stream state to close aft...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/389#discussion_r48120660
--- Diff: proxy/http2/HTTP2.cc ---
@@ -665,11 +666,19 @@ http2_decode_header_blocks(HTTPHdr *hdr, const uint8_t *buf_start, const uint8_t
}
}
+ // turn on that we have a trailer header
+ char trailer_name[] = "trailer";
+ if (name_len == (sizeof(trailer_name) - 1) && strncmp(name, trailer_name, sizeof(trailer_name) - 1) == 0) {
+ trailing_header = true;
--- End diff --
oh, I didn't notice '&' in argument. sorry:p
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---