[GitHub] kafka pull request #4303: KAFKA-6319: Quote strings stored in JSON configs

[rajinisivaram <gi...@git.apache.org>]

GitHub user rajinisivaram opened a pull request:

    https://github.com/apache/kafka/pull/4303

    KAFKA-6319: Quote strings stored in JSON configs

    This is required for ACLs where SSL principals contain special characters (e.g. comma) that are escaped using backslash. The strings need to be quoted for JSON to ensure that the JSON stored in ZK is valid.
    Also converted `SslEndToEndAuthorizationTest` to use a principal with special characters to ensure that this path is tested.
    
    *More detailed description of your change,
    if necessary. The PR title and PR message become
    the squashed commit message, so use a separate
    comment to ping reviewers.*
    
    *Summary of testing strategy (including rationale)
    for the feature or bug fix. Unit and/or integration
    tests are expected for any behaviour change and
    system tests should be considered for larger changes.*
    
    ### Committer Checklist (excluded from commit message)
    - [ ] Verify design and implementation 
    - [ ] Verify test coverage and CI build status
    - [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rajinisivaram/kafka KAFKA-6319

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4303
    
----
commit 9518f465a76b3431a36777d83d57bf1430eaa302
Author: Rajini Sivaram <ra...@googlemail.com>
Date:   2017-12-07T20:00:03Z

    KAFKA-6319: Quote strings in JSON to enable ACLs for principals with special chars

----


---

[GitHub] kafka pull request #4303: KAFKA-6319: Quote strings stored in JSON configs

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/4303


---