You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/07 04:45:53 UTC
[GitHub] [spark] xinrong-databricks opened a new pull request #34825: [SPARK-37525][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
xinrong-databricks opened a new pull request #34825:
URL: https://github.com/apache/spark/pull/34825
### What changes were proposed in this pull request?
Implement days, seconds, microseconds properties of TimedeltaIndex
### Why are the changes needed?
To be consistent with pandas.
### Does this PR introduce _any_ user-facing change?
Yes.
### How was this patch tested?
Unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992306437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992199116
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50597/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-993190246
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50637/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-993166698
**[Test build #146164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146164/testReport)** for PR 34825 at commit [`17367bc`](https://github.com/apache/spark/commit/17367bc70a92dd1ebae064ccd4e78d07c34ad5ff).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987614348
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50448/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989602472
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50505/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989546330
**[Test build #146029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146029/testReport)** for PR 34825 at commit [`c62b709`](https://github.com/apache/spark/commit/c62b709b4ba484e184f10fb66d8c3ecfe2d77590).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989562672
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50503/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992206596
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50599/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987620465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987666854
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50454/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992174495
**[Test build #146122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146122/testReport)** for PR 34825 at commit [`48170bd`](https://github.com/apache/spark/commit/48170bd231b0bc140876160e2d4362a8f3249afb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989600271
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50503/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37525][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987573232
**[Test build #145973 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145973/testReport)** for PR 34825 at commit [`fcca9ec`](https://github.com/apache/spark/commit/fcca9ec78677b3a303af9a1c73cc1e67fb04c9f3).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987681195
FYI @ueshin @HyukjinKwon @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989546330
**[Test build #146029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146029/testReport)** for PR 34825 at commit [`c62b709`](https://github.com/apache/spark/commit/c62b709b4ba484e184f10fb66d8c3ecfe2d77590).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989567262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34825:
URL: https://github.com/apache/spark/pull/34825#discussion_r765464406
##########
File path: python/pyspark/pandas/indexes/timedelta.py
##########
@@ -111,3 +126,80 @@ def __getattr__(self, item: str) -> Any:
return partial(property_or_func, self)
raise AttributeError("'TimedeltaIndex' object has no attribute '{}'".format(item))
+
+ @property
+ def days(self) -> Index:
+ """
+ Number of days for each element.
+ """
+
+ @no_type_check
+ def pandas_days(x) -> int:
+ return x.days
+
+ return ps.Index(self.to_series().transform(pandas_days))
+
+ @property
+ def seconds(self) -> Index:
+ """
+ Number of seconds (>= 0 and less than 1 day) for each element.
+ """
+ sdf = self._internal.spark_frame
+ hour_scol_name = verify_temp_column_name(sdf, "__hour_column__")
+ minute_scol_name = verify_temp_column_name(sdf, "__minute_column__")
+ second_scol_name = verify_temp_column_name(sdf, "__second_column__")
+ sum_scol_name = verify_temp_column_name(sdf, "__sum_column__")
+
+ # Extract the hours part, minutes part, seconds part and its fractional part with microseconds
+ sdf = sdf.select(
+ F.expr("date_part('HOUR', %s)" % SPARK_DEFAULT_INDEX_NAME),
+ F.expr("date_part('MINUTE', %s)" % SPARK_DEFAULT_INDEX_NAME),
+ F.expr("date_part('SECOND', %s)" % SPARK_DEFAULT_INDEX_NAME),
+ ).toDF(hour_scol_name, minute_scol_name, second_scol_name)
+
+ # Transfer to microseconds
+ sdf = sdf.withColumn(
+ sum_scol_name,
+ F.when(
+ scol_for(sdf, hour_scol_name) < 0,
+ SECONDS_PER_DAY + scol_for(sdf, hour_scol_name) * SECONDS_PER_HOUR,
+ ).otherwise(scol_for(sdf, hour_scol_name) * SECONDS_PER_HOUR)
+ + F.when(
+ scol_for(sdf, minute_scol_name) < 0,
+ SECONDS_PER_DAY + scol_for(sdf, minute_scol_name) * SECONDS_PER_MINUTE,
+ ).otherwise(scol_for(sdf, minute_scol_name) * SECONDS_PER_MINUTE)
+ + F.when(
+ scol_for(sdf, second_scol_name) < 0,
+ SECONDS_PER_DAY + scol_for(sdf, second_scol_name),
+ ).otherwise(scol_for(sdf, second_scol_name)),
+ ).select(sum_scol_name)
+ return Index(first_series(DataFrame(sdf))).astype(int).rename(self.name)
+
+ @property
+ def microseconds(self) -> Index:
+ """
+ Number of microseconds (>= 0 and less than 1 second) for each element.
+ """
+ sdf = self._internal.spark_frame
+ second_scol_name = verify_temp_column_name(sdf, "__second_column__")
+
+ # Extract the seconds part and its fractional part with microseconds per element
+ sdf = sdf.select(F.expr("date_part('SECOND', %s)" % SPARK_DEFAULT_INDEX_NAME)).toDF(
Review comment:
Here too. Should be able to do it without `DataFrame.select`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989560248
**[Test build #146029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146029/testReport)** for PR 34825 at commit [`c62b709`](https://github.com/apache/spark/commit/c62b709b4ba484e184f10fb66d8c3ecfe2d77590).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-993226753
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50637/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-993166698
**[Test build #146164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146164/testReport)** for PR 34825 at commit [`17367bc`](https://github.com/apache/spark/commit/17367bc70a92dd1ebae064ccd4e78d07c34ad5ff).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-993269091
CC @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-993265364
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146164/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-994239561
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-993226753
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50637/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #34825:
URL: https://github.com/apache/spark/pull/34825#discussion_r765460187
##########
File path: python/pyspark/pandas/indexes/timedelta.py
##########
@@ -111,3 +115,66 @@ def __getattr__(self, item: str) -> Any:
return partial(property_or_func, self)
raise AttributeError("'TimedeltaIndex' object has no attribute '{}'".format(item))
+
+ @property
+ def days(self) -> Index:
+ """
+ Number of days for each element.
+ """
+ sdf = self._internal.spark_frame.select(
Review comment:
Considering the negative time delta, `Series.apply` is used instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989555630
**[Test build #146027 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146027/testReport)** for PR 34825 at commit [`d39be08`](https://github.com/apache/spark/commit/d39be088659c1fa04b9a126a7951e3bb2d22072c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989542364
**[Test build #146027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146027/testReport)** for PR 34825 at commit [`d39be08`](https://github.com/apache/spark/commit/d39be088659c1fa04b9a126a7951e3bb2d22072c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989602472
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50505/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #34825:
URL: https://github.com/apache/spark/pull/34825#discussion_r767460516
##########
File path: python/pyspark/pandas/tests/indexes/test_timedelta.py
##########
@@ -0,0 +1,84 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from datetime import timedelta
+
+import pandas as pd
+
+import pyspark.pandas as ps
+from pyspark.testing.pandasutils import PandasOnSparkTestCase, TestUtils
+
+
+class TimedeltaIndexTest(PandasOnSparkTestCase, TestUtils):
Review comment:
Makes sense, added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34825:
URL: https://github.com/apache/spark/pull/34825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-993265364
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146164/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-993253157
**[Test build #146164 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146164/testReport)** for PR 34825 at commit [`17367bc`](https://github.com/apache/spark/commit/17367bc70a92dd1ebae064ccd4e78d07c34ad5ff).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989600271
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50503/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987620468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992177100
**[Test build #146124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146124/testReport)** for PR 34825 at commit [`caad4b4`](https://github.com/apache/spark/commit/caad4b458622c8c65901c40fbf26811069465a28).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989542364
**[Test build #146027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146027/testReport)** for PR 34825 at commit [`d39be08`](https://github.com/apache/spark/commit/d39be088659c1fa04b9a126a7951e3bb2d22072c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34825:
URL: https://github.com/apache/spark/pull/34825#discussion_r765464278
##########
File path: python/pyspark/pandas/indexes/timedelta.py
##########
@@ -111,3 +126,80 @@ def __getattr__(self, item: str) -> Any:
return partial(property_or_func, self)
raise AttributeError("'TimedeltaIndex' object has no attribute '{}'".format(item))
+
+ @property
+ def days(self) -> Index:
+ """
+ Number of days for each element.
+ """
+
+ @no_type_check
+ def pandas_days(x) -> int:
+ return x.days
+
+ return ps.Index(self.to_series().transform(pandas_days))
+
+ @property
+ def seconds(self) -> Index:
+ """
+ Number of seconds (>= 0 and less than 1 day) for each element.
+ """
+ sdf = self._internal.spark_frame
+ hour_scol_name = verify_temp_column_name(sdf, "__hour_column__")
+ minute_scol_name = verify_temp_column_name(sdf, "__minute_column__")
+ second_scol_name = verify_temp_column_name(sdf, "__second_column__")
+ sum_scol_name = verify_temp_column_name(sdf, "__sum_column__")
+
+ # Extract the hours part, minutes part, seconds part and its fractional part with microseconds
+ sdf = sdf.select(
+ F.expr("date_part('HOUR', %s)" % SPARK_DEFAULT_INDEX_NAME),
+ F.expr("date_part('MINUTE', %s)" % SPARK_DEFAULT_INDEX_NAME),
+ F.expr("date_part('SECOND', %s)" % SPARK_DEFAULT_INDEX_NAME),
Review comment:
Hm .. the index name might not be `SPARK_DEFAULT_INDEX_NAME` ... right?
I think you can still do all of them without using `DataFrame.select`. Can we directly use `F.when(...).otherwise()` like you did with `self.to_series().transform`? We can just replace `hour_scol_name`, `minute_scol_name` and `second_scol_name` directly to `F.expr(...)` without `DataFrame.select`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987666889
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50454/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992243442
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50597/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989567262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992255440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992249336
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50599/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992177100
**[Test build #146124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146124/testReport)** for PR 34825 at commit [`caad4b4`](https://github.com/apache/spark/commit/caad4b458622c8c65901c40fbf26811069465a28).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992174495
**[Test build #146122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146122/testReport)** for PR 34825 at commit [`48170bd`](https://github.com/apache/spark/commit/48170bd231b0bc140876160e2d4362a8f3249afb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987592805
**[Test build #145979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145979/testReport)** for PR 34825 at commit [`8d7caf4`](https://github.com/apache/spark/commit/8d7caf4b3a5c492aea632751ccb56faf8d143fce).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987626775
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50454/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34825:
URL: https://github.com/apache/spark/pull/34825#discussion_r763829679
##########
File path: python/pyspark/pandas/indexes/timedelta.py
##########
@@ -111,3 +115,66 @@ def __getattr__(self, item: str) -> Any:
return partial(property_or_func, self)
raise AttributeError("'TimedeltaIndex' object has no attribute '{}'".format(item))
+
+ @property
+ def days(self) -> Index:
+ """
+ Number of days for each element.
+ """
+ sdf = self._internal.spark_frame.select(
Review comment:
Hm .. shouldn't we use `self.spark.column` or with `_with_new_scol` instead of doing a select? Otherwise, the output will have a different anchor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #34825:
URL: https://github.com/apache/spark/pull/34825#discussion_r763908800
##########
File path: python/pyspark/pandas/indexes/timedelta.py
##########
@@ -111,3 +115,66 @@ def __getattr__(self, item: str) -> Any:
return partial(property_or_func, self)
raise AttributeError("'TimedeltaIndex' object has no attribute '{}'".format(item))
+
+ @property
+ def days(self) -> Index:
+ """
+ Number of days for each element.
+ """
+ sdf = self._internal.spark_frame.select(
Review comment:
Makes sense, let me adjust that, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #34825:
URL: https://github.com/apache/spark/pull/34825#discussion_r766054166
##########
File path: python/pyspark/pandas/indexes/timedelta.py
##########
@@ -111,3 +126,80 @@ def __getattr__(self, item: str) -> Any:
return partial(property_or_func, self)
raise AttributeError("'TimedeltaIndex' object has no attribute '{}'".format(item))
+
+ @property
+ def days(self) -> Index:
+ """
+ Number of days for each element.
+ """
+
+ @no_type_check
+ def pandas_days(x) -> int:
+ return x.days
+
+ return ps.Index(self.to_series().transform(pandas_days))
+
+ @property
+ def seconds(self) -> Index:
+ """
+ Number of seconds (>= 0 and less than 1 day) for each element.
+ """
+ sdf = self._internal.spark_frame
+ hour_scol_name = verify_temp_column_name(sdf, "__hour_column__")
+ minute_scol_name = verify_temp_column_name(sdf, "__minute_column__")
+ second_scol_name = verify_temp_column_name(sdf, "__second_column__")
+ sum_scol_name = verify_temp_column_name(sdf, "__sum_column__")
+
+ # Extract the hours part, minutes part, seconds part and its fractional part with microseconds
+ sdf = sdf.select(
+ F.expr("date_part('HOUR', %s)" % SPARK_DEFAULT_INDEX_NAME),
+ F.expr("date_part('MINUTE', %s)" % SPARK_DEFAULT_INDEX_NAME),
+ F.expr("date_part('SECOND', %s)" % SPARK_DEFAULT_INDEX_NAME),
Review comment:
We can add the function in `.../pandas/spark/functions.py` and use `_call_udf` in it
##########
File path: python/pyspark/pandas/tests/indexes/test_timedelta.py
##########
@@ -0,0 +1,84 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from datetime import timedelta
+
+import pandas as pd
+
+import pyspark.pandas as ps
+from pyspark.testing.pandasutils import PandasOnSparkTestCase, TestUtils
+
+
+class TimedeltaIndexTest(PandasOnSparkTestCase, TestUtils):
Review comment:
We need to add this to `dev/sparktestsupport/modules.py` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989569135
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50505/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989594296
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50503/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992255434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992299684
**[Test build #146124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146124/testReport)** for PR 34825 at commit [`caad4b4`](https://github.com/apache/spark/commit/caad4b458622c8c65901c40fbf26811069465a28).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34825:
URL: https://github.com/apache/spark/pull/34825#discussion_r765467231
##########
File path: python/pyspark/pandas/indexes/timedelta.py
##########
@@ -111,3 +126,80 @@ def __getattr__(self, item: str) -> Any:
return partial(property_or_func, self)
raise AttributeError("'TimedeltaIndex' object has no attribute '{}'".format(item))
+
+ @property
+ def days(self) -> Index:
+ """
+ Number of days for each element.
+ """
+
+ @no_type_check
+ def pandas_days(x) -> int:
+ return x.days
+
+ return ps.Index(self.to_series().transform(pandas_days))
+
+ @property
+ def seconds(self) -> Index:
+ """
+ Number of seconds (>= 0 and less than 1 day) for each element.
+ """
+ sdf = self._internal.spark_frame
+ hour_scol_name = verify_temp_column_name(sdf, "__hour_column__")
+ minute_scol_name = verify_temp_column_name(sdf, "__minute_column__")
+ second_scol_name = verify_temp_column_name(sdf, "__second_column__")
+ sum_scol_name = verify_temp_column_name(sdf, "__sum_column__")
+
+ # Extract the hours part, minutes part, seconds part and its fractional part with microseconds
+ sdf = sdf.select(
+ F.expr("date_part('HOUR', %s)" % SPARK_DEFAULT_INDEX_NAME),
+ F.expr("date_part('MINUTE', %s)" % SPARK_DEFAULT_INDEX_NAME),
+ F.expr("date_part('SECOND', %s)" % SPARK_DEFAULT_INDEX_NAME),
Review comment:
For `SPARK_DEFAULT_INDEX_NAME`, I think we might have to directly call `org.apache.spark.sql.catalyst.expressions.DatePart` to invoke Spark column. Feel free to add a function at `PythonSQLUtils` such as:
```scala
// This is only used in Python side to pass `Column` instances with other expressions
// instead of plain column names.
def datePart(field: Column, source: Column, child: Column): Column =
Column(DatePart(field.expr, source.expr, child.expr))
```
and call it in Python side like:
```python
jvm.PythonSQLUtils.castTimestampNTZToLong(functions.lit('HOUR')._jc, self.spark.column._jc)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-993213417
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50637/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37525][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987584542
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50448/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37525][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987592805
**[Test build #145979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145979/testReport)** for PR 34825 at commit [`8d7caf4`](https://github.com/apache/spark/commit/8d7caf4b3a5c492aea632751ccb56faf8d143fce).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #34825:
URL: https://github.com/apache/spark/pull/34825#discussion_r767458829
##########
File path: python/pyspark/pandas/indexes/timedelta.py
##########
@@ -111,3 +126,80 @@ def __getattr__(self, item: str) -> Any:
return partial(property_or_func, self)
raise AttributeError("'TimedeltaIndex' object has no attribute '{}'".format(item))
+
+ @property
+ def days(self) -> Index:
+ """
+ Number of days for each element.
+ """
+
+ @no_type_check
+ def pandas_days(x) -> int:
+ return x.days
+
+ return ps.Index(self.to_series().transform(pandas_days))
+
+ @property
+ def seconds(self) -> Index:
+ """
+ Number of seconds (>= 0 and less than 1 day) for each element.
+ """
+ sdf = self._internal.spark_frame
+ hour_scol_name = verify_temp_column_name(sdf, "__hour_column__")
+ minute_scol_name = verify_temp_column_name(sdf, "__minute_column__")
+ second_scol_name = verify_temp_column_name(sdf, "__second_column__")
+ sum_scol_name = verify_temp_column_name(sdf, "__sum_column__")
+
+ # Extract the hours part, minutes part, seconds part and its fractional part with microseconds
+ sdf = sdf.select(
+ F.expr("date_part('HOUR', %s)" % SPARK_DEFAULT_INDEX_NAME),
+ F.expr("date_part('MINUTE', %s)" % SPARK_DEFAULT_INDEX_NAME),
+ F.expr("date_part('SECOND', %s)" % SPARK_DEFAULT_INDEX_NAME),
Review comment:
Thank you @HyukjinKwon and @ueshin ! Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-989602448
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50505/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992306437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-992295873
**[Test build #146122 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146122/testReport)** for PR 34825 at commit [`48170bd`](https://github.com/apache/spark/commit/48170bd231b0bc140876160e2d4362a8f3249afb).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37525][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987565641
**[Test build #145973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145973/testReport)** for PR 34825 at commit [`fcca9ec`](https://github.com/apache/spark/commit/fcca9ec78677b3a303af9a1c73cc1e67fb04c9f3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34825: [SPARK-37525][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987565641
**[Test build #145973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145973/testReport)** for PR 34825 at commit [`fcca9ec`](https://github.com/apache/spark/commit/fcca9ec78677b3a303af9a1c73cc1e67fb04c9f3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34825: [SPARK-37525][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987589321
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145973/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34825: [SPARK-37525][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987589321
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145973/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987613633
**[Test build #145979 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145979/testReport)** for PR 34825 at commit [`8d7caf4`](https://github.com/apache/spark/commit/8d7caf4b3a5c492aea632751ccb56faf8d143fce).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34825: [SPARK-37563][PYTHON] Implement days, seconds, microseconds properties of TimedeltaIndex
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34825:
URL: https://github.com/apache/spark/pull/34825#issuecomment-987666889
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50454/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org