You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/10 02:13:41 UTC

[GitHub] [incubator-devlake] klesh commented on issue #2130: [Feature][Helper/ApiCollector] Make query functions support getting options information from context

klesh commented on issue #2130:
URL: https://github.com/apache/incubator-devlake/issues/2130#issuecomment-1151841149

   The use case doesn't seem legit.
   Why would authentication get passed by `task.options`?
   It should be with `connection` and handled by `ApiClient.SetBeforeFunction`, Check `plugins/github/tasks/api_client.go` for detail.
   Do you have any actual cases to prove the necessity of this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org