You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/01/24 08:42:35 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #39714: [SPARK-42166][K8S] Make `docker-image-tool.sh` usage message up-to-date
dongjoon-hyun opened a new pull request, #39714:
URL: https://github.com/apache/spark/pull/39714
### What changes were proposed in this pull request?
This PR aims to make `docker-image-tool.sh` usage message up-to-date.
### Why are the changes needed?
- Use `v3.4.0` instead of all EOL versions (v2.3.0, v3.0.0)
- Use the smallest multi-arch image, `11-jre`, instead of `11-jre-focal`.
```
$ docker images | grep eclipse-temurin | sort -k7
eclipse-temurin 11-jre 87a0df44b0d1 6 weeks ago 239MB
eclipse-temurin 11-jre-focal 0cb88201ea2b 6 weeks ago 245MB
eclipse-temurin 17-jre 096f7591e8eb 6 weeks ago 260MB
eclipse-temurin 11 a20b0d225174 6 weeks ago 435MB
eclipse-temurin 17 2ed42194c6b0 6 weeks ago 450MB
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #39714: [SPARK-42166][K8S] Make `docker-image-tool.sh` usage message up-to-date
Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun commented on PR #39714:
URL: https://github.com/apache/spark/pull/39714#issuecomment-1401870194
late LGTM.
> Use the smallest multi-arch image tag example, 11-jre, instead of 11-jre-focal.
FYI, According to https://github.com/docker-library/official-images/blob/master/library/eclipse-temurin#L84-L85 .
- 11-jre == 11-jre-jammy (Ubuntu 22.04)
- 11-jre-facal (Ubuntu 20.04)
I think it's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39714: [SPARK-42166][K8S] Make `docker-image-tool.sh` usage message up-to-date
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39714:
URL: https://github.com/apache/spark/pull/39714#issuecomment-1401692271
Merged to master for Apache Spark 3.4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39714: [SPARK-42166][K8S] Make `docker-image-tool.sh` usage message up-to-date
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39714:
URL: https://github.com/apache/spark/pull/39714#issuecomment-1401687848
Thank you, @HyukjinKwon !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #39714: [SPARK-42166][K8S] Make `docker-image-tool.sh` usage message up-to-date
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #39714: [SPARK-42166][K8S] Make `docker-image-tool.sh` usage message up-to-date
URL: https://github.com/apache/spark/pull/39714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39714: [SPARK-42166][K8S] Make `docker-image-tool.sh` usage message up-to-date
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39714:
URL: https://github.com/apache/spark/pull/39714#issuecomment-1401562599
Could you review this, @Yikun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org