You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/03/17 12:08:20 UTC

[GitHub] [bookkeeper] hangc0276 opened a new pull request #2290: fix some stats monitor metrics

hangc0276 opened a new pull request #2290: fix some stats monitor metrics
URL: https://github.com/apache/bookkeeper/pull/2290
 
 
   Descriptions of the changes in this PR:
   
   The journalStats.getJournalQueueSize increase once and decrease twice, so this stat metric will be negative.
   
   It increases in `logAddEntry` function and decrease in `QueueEntry recall` methord and Journal main thread run methord.
   
   so we should delete the decrease in journal main thread run methord.
   
   ```
   queue.put(QueueEntry.create(
                   entry, ackBeforeSync,  ledgerId, entryId, cb, ctx, MathUtils.nowInNano(),
                   journalStats.getJournalAddEntryStats(),
                   journalStats.getJournalQueueSize()))
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [bookkeeper] sijie merged pull request #2290: fix some stats monitor metrics

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #2290: fix some stats monitor metrics
URL: https://github.com/apache/bookkeeper/pull/2290
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services