You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by cx...@apache.org on 2018/06/19 09:41:24 UTC
[37/50] [abbrv] incubator-weex git commit: [WEEX-460][iOS] Fix
ImageComponent with placeholder of URL cannot display placeholder if main
image cannot be downloaded.
[WEEX-460][iOS] Fix ImageComponent with placeholder of URL cannot display placeholder if main image cannot be downloaded.
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/d1d80057
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/d1d80057
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/d1d80057
Branch: refs/heads/release
Commit: d1d80057b2c6b9cf1be47985e3d9cfab29b28140
Parents: 91d7134
Author: 神漠 <qi...@alipay.com>
Authored: Wed Jun 13 21:14:11 2018 +0800
Committer: Adam Feng <cx...@gmail.com>
Committed: Thu Jun 14 14:54:15 2018 +0800
----------------------------------------------------------------------
ios/sdk/WeexSDK/Sources/Component/WXImageComponent.m | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/d1d80057/ios/sdk/WeexSDK/Sources/Component/WXImageComponent.m
----------------------------------------------------------------------
diff --git a/ios/sdk/WeexSDK/Sources/Component/WXImageComponent.m b/ios/sdk/WeexSDK/Sources/Component/WXImageComponent.m
index 8ab354b..7f177f3 100644
--- a/ios/sdk/WeexSDK/Sources/Component/WXImageComponent.m
+++ b/ios/sdk/WeexSDK/Sources/Component/WXImageComponent.m
@@ -381,7 +381,7 @@ WX_EXPORT_METHOD(@selector(save:))
[[self imageLoader] setImageViewWithURL:(UIImageView*)self.view url:[NSURL URLWithString:newURL] placeholderImage:nil options:userInfo progress:^(NSInteger receivedSize, NSInteger expectedSize) {
// progress when loading image
} completed:^(UIImage *image, NSError *error, WXImageLoaderCacheType cacheType, NSURL *imageURL) {
- __strong typeof(weakSelf) strongSelf = weakSelf;
+ __strong typeof(weakSelf) strongSelf = weakSelf;
if (strongSelf == nil) {
return;
}
@@ -434,7 +434,7 @@ WX_EXPORT_METHOD(@selector(save:))
[strongSelf cancelImage];
void(^downloadFailed)(NSString *, NSError *) = ^void(NSString *url, NSError *error) {
- strongSelf.imageDownloadFinish = YES;
+ weakSelf.imageDownloadFinish = YES;
WXLogError(@"Error downloading image: %@, detail:%@", url, [error localizedDescription]);
};