You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/06/24 15:47:04 UTC
[jira] [Commented] (WICKET-5935) IoC Guice: cache proxies and fail
on creation when binding is missing
[ https://issues.apache.org/jira/browse/WICKET-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599437#comment-14599437 ]
ASF GitHub Bot commented on WICKET-5935:
----------------------------------------
GitHub user selckin opened a pull request:
https://github.com/apache/wicket/pull/130
WICKET-5935: Guice IoC: cache proxies & fail fast
- cache proxies in the same way the spring ioc caches them
- If a bean has no binding the exception is now throw on construction
instead of when that bean/proxy is used.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/selckin/wicket master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit 347c8ade85383a6699cebfe9e1e19a60dab69bfe
Author: Thomas Matthijs <th...@actonomy.com>
Date: 2015-06-24T13:26:45Z
WICKET-5935: Guice IoC: cache proxies & fail fast
- cache proxies in the same way the spring ioc caches them
- If a bean has no binding the exception is now throw on construction
instead of when that bean/proxy is used.
----
> IoC Guice: cache proxies and fail on creation when binding is missing
> ---------------------------------------------------------------------
>
> Key: WICKET-5935
> URL: https://issues.apache.org/jira/browse/WICKET-5935
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-guice
> Reporter: selckin
> Priority: Minor
>
> - Cache guice proxies in the same way the spring ones are cached for performance & consistency between.
> - Fail on component creation if a guice binding is missing instead of when the binding/proxy is first used
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)