You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 14:22:42 UTC
[GitHub] [airflow] kishvanchee opened a new pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
kishvanchee opened a new pull request #11307:
URL: https://github.com/apache/airflow/pull/11307
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This change is related to #11178 for `subdag_operator`.
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11307:
URL: https://github.com/apache/airflow/pull/11307#issuecomment-706728083
@kishvanchee have you check if there's need for any changes in documenation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11307:
URL: https://github.com/apache/airflow/pull/11307#issuecomment-740374385
[The Workflow run](https://github.com/apache/airflow/actions/runs/407257284) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #11307:
URL: https://github.com/apache/airflow/pull/11307#issuecomment-740265575
Rebased, fixed coflicts, squashed and fixed few more places
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11307:
URL: https://github.com/apache/airflow/pull/11307#issuecomment-740265575
Rebased, and fixed few more places
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11307:
URL: https://github.com/apache/airflow/pull/11307#issuecomment-704325204
[The Build Workflow run](https://github.com/apache/airflow/actions/runs/291625011) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11307:
URL: https://github.com/apache/airflow/pull/11307#issuecomment-740277400
[The Workflow run](https://github.com/apache/airflow/actions/runs/407135444) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11307:
URL: https://github.com/apache/airflow/pull/11307
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11307:
URL: https://github.com/apache/airflow/pull/11307#issuecomment-721446281
Can you please rebase your PR on latest Master since we have applied [Black](https://github.com/apache/airflow/commit/4e8f9cc8d02b29c325b8a5a76b4837671bdf5f68) and [PyUpgrade](https://github.com/apache/airflow/commit/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5) on Master.
It will help if your squash your commits into single commit first so that there are less conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11307:
URL: https://github.com/apache/airflow/pull/11307#issuecomment-740374639
[The Workflow run](https://github.com/apache/airflow/actions/runs/407292248) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11307:
URL: https://github.com/apache/airflow/pull/11307#issuecomment-740266633
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11307:
URL: https://github.com/apache/airflow/pull/11307#issuecomment-740277122
[The Workflow run](https://github.com/apache/airflow/actions/runs/407126966) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11307: Moved subdag_operator.py to subdag.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11307:
URL: https://github.com/apache/airflow/pull/11307#issuecomment-706734602
@turbaszek No I have not yet. I was hoping to do each PR sequentially even though it's already ready because of rebase conflicts. Rebasing multiple of my PRs might end up breaking things. Currently please have a look at #11293 , which is failing for the core builds. I have rebased and pushed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org