Re: [jira] Created: (PIVOT-206) Review framework classes for serializability

[Greg Brown <gk...@mac.com>]

Sure. I think all of our collection classes should be serializable, and, at the moment, some are probably not. Not all of our comparators necessarily need to be serializable, but let's try to identify the ones that do. Can you send out a list of the classes you think should be serializable?

 
On Wednesday, August 05, 2009, at 10:01AM, "Sandro Martini" <sa...@gmail.com> wrote:
>Hi to all,
>tell me if i can help on this, or assign to me directly if desired ...
>
>Bye
>
>

Re: [jira] Created: (PIVOT-206) Review framework classes for serializability

[Sandro Martini <sa...@gmail.com>]

Hi Greg,
many thanks to Findbugs ...

Comparator doesn't implement Serializable
Folder.java:43 org.apache.pivot.io.Folder$FileNameComparator
implements Comparator but not Serializable
TreeView.java:331 org.apache.pivot.wtk.TreeView$PathComparator
implements Comparator but not Serializable
TreeNodeComparator.java:1
org.apache.pivot.tutorials.TreeNodeComparator implements Comparator
but not Serializable
TableView.java:484 org.apache.pivot.wtk.TableView$RowComparator
implements Comparator but not Serializable
FileList.java:32 org.apache.pivot.io.FileList$FilePathComparator
implements Comparator but not Serializable
Element.java:72 org.apache.pivot.wtk.text.Element$NodeOffsetComparator
implements Comparator but not Serializable

Tell me if i have to do the work.

Bye