You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by ja...@apache.org on 2022/10/16 17:10:03 UTC

[couchdb] branch set-test-prometheus-port updated (cfcb234dd -> 57d47cb90)

This is an automated email from the ASF dual-hosted git repository.

jaydoane pushed a change to branch set-test-prometheus-port
in repository https://gitbox.apache.org/repos/asf/couchdb.git


 discard cfcb234dd Config set test prometheus port
     new 57d47cb90 Make test prometheus port explicit

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (cfcb234dd)
            \
             N -- N -- N   refs/heads/set-test-prometheus-port (57d47cb90)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:


[couchdb] 01/01: Make test prometheus port explicit

Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

jaydoane pushed a commit to branch set-test-prometheus-port
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit 57d47cb905b004d048473140ecf62346e288aac7
Author: Jay Doane <ja...@apache.org>
AuthorDate: Sat Oct 15 17:23:51 2022 -0700

    Make test prometheus port explicit
    
    These tests currently pass without this config parameter being set
    because it gets that configuration from a test template. However, this
    is fragile, and it's better practice to keep everything in one place.
    
    This makes the configuration explicit.
---
 src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl b/src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl
index 160c1bea7..00cbd25fe 100644
--- a/src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl
+++ b/src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl
@@ -81,6 +81,7 @@ setup_prometheus(WithAdditionalPort) ->
         WithAdditionalPort,
         Persist
     ),
+    ok = config:set("prometheus", "port", ?PROM_PORT),
     % It's already started by default, so restart to pick up config
     ok = application:stop(couch_prometheus),
     ok = application:start(couch_prometheus),