You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2012/02/01 01:15:58 UTC

DO NOT REPLY [Bug 52569] New: [PATCH] DConRef (0x51) record implementation

https://issues.apache.org/bugzilla/show_bug.cgi?id=52569

             Bug #: 52569
           Summary: [PATCH] DConRef (0x51) record implementation
           Product: POI
           Version: 3.8-dev
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HSSF
        AssignedTo: dev@poi.apache.org
        ReportedBy: niklas.rehfeld@gmail.com
    Classification: Unclassified


This patch contains an implementation of DConRef record (SID = 0x51), which
holds data sources for PivotTables and other data consolidation. 

The patch contains two new files:
* DConRefRecord.java which extends StandardRecord and implements the DConRef
structure 
* TestDConRefRecord.java which contains the unit tests for the new class.

Also there are very minor changes to the following files, so they make use of
the new class: 
* RecordFactory.java 
* AllRecordTests.java 
* BiffViewer.java

The DConRef implementation does not support changing the record, as I wasn't
confident that it wouldn't break anything else when you change it. 

The patch passes all existing unit tests as well as the new ones. 

The patch was created manually, as the patch.xml method kept missing out one of
the changed files for some reason.

Please let me know of any problems with this patch, as this is my first time
contributing to this project.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

DO NOT REPLY [Bug 52569] [PATCH] DConRef (0x51) record implementation

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52569

Yegor Kozlov <ye...@dinom.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Yegor Kozlov <ye...@dinom.ru> 2012-02-07 09:01:25 UTC ---
Thanks for the patch, applied in r1241380

Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

DO NOT REPLY [Bug 52569] [PATCH] DConRef (0x51) record implementation

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52569

--- Comment #2 from Niklas Rehfeld <ni...@gmail.com> 2012-02-01 00:19:30 UTC ---
Created attachment 28246
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28246
changes to RecordFactory, BiffViewer and AllRecordTests to use new classes

patch contains some small changes to RecordFactory.java (register SID 0x051 to
create DConRefRecord) BiffViewer (same) and AllRecordTests (use
TestDConRefRecord tests)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

DO NOT REPLY [Bug 52569] [PATCH] DConRef (0x51) record implementation

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52569

--- Comment #1 from Niklas Rehfeld <ni...@gmail.com> 2012-02-01 00:17:25 UTC ---
Created attachment 28244
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28244
DConRefRecord and TestDConRefRecord classes

The new classes that implement DConRefRecord and its associated unit tests.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org