You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2025/07/25 20:26:47 UTC

(superset) branch master updated (5f11f9097a -> e741a3167f)

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


    from 5f11f9097a fix: Charts list is displaying empty dataset names when there's no schema (#34315)
     add e741a3167f feat: add a theme CRUD page to manage themes (#34182)

No new revisions were added by this update.

Summary of changes:
 .pre-commit-config.yaml                            |   4 +-
 LLMS.md                                            |  45 +-
 docs/docs/configuration/theming.mdx                |  89 +++-
 docs/package.json                                  |   3 +-
 superset-frontend/package-lock.json                |   2 +-
 superset-frontend/package.json                     |   2 +-
 .../src/components/AsyncAceEditor/index.tsx        |   7 +-
 .../AsyncAceEditor/useJsonValidation.test.ts       |  75 +++
 .../components/AsyncAceEditor/useJsonValidation.ts |  82 ++++
 .../src/components/CodeSyntaxHighlighter/index.tsx |  11 +-
 .../src/components/Icons/BaseIcon.tsx              |   8 +-
 .../src/components/InfoTooltip/index.tsx           |   4 +-
 .../src/components/Label/index.tsx                 |   4 +-
 .../src/components/ThemeEditor/index.tsx           | 150 ------
 .../src/components/ThemeSelect/index.tsx           |  99 ++--
 .../superset-ui-core/src/theme/Theme.test.tsx      |  18 -
 .../packages/superset-ui-core/src/theme/Theme.tsx  |  70 +--
 .../packages/superset-ui-core/src/theme/index.tsx  |   3 +
 .../packages/superset-ui-core/src/theme/types.ts   |   9 +
 .../src/theme/utils/themeUtils.test.ts             | 134 ++++++
 .../superset-ui-core/src/theme/utils/themeUtils.ts | 113 +++++
 .../superset-ui-core/src/utils/featureFlags.ts     |   3 +-
 .../src/BigNumber/BigNumberViz.tsx                 | 382 +++++++--------
 .../src/Sankey/transformProps.ts                   |   4 +-
 .../src/Tree/transformProps.ts                     |   4 +-
 .../plugin-chart-echarts/src/components/Echart.tsx |  85 ++--
 .../src/components/CrudThemeProvider.tsx           |  76 +++
 .../components/ErrorMessage/BasicErrorAlert.tsx    |   9 +-
 .../src/components/ListView/Filters/Search.tsx     |   8 +-
 superset-frontend/src/components/Tag/index.tsx     |   3 +-
 .../src/dashboard/actions/dashboardInfo.ts         |  46 ++
 .../components/CssEditor/CssEditor.test.tsx        |  38 +-
 .../src/dashboard/components/CssEditor/index.tsx   | 224 +++++++--
 .../DashboardBuilder/DashboardBuilder.test.tsx     |   1 +
 .../dashboard/components/Header/Header.test.tsx    |   6 +-
 .../src/dashboard/components/Header/types.ts       |   4 +
 .../Header/useHeaderActionsDropdownMenu.tsx        |  18 +-
 .../dashboard/components/PropertiesModal/index.tsx |  10 +-
 .../components/RefreshIntervalModal.test.tsx       |  14 +-
 .../src/dashboard/components/SaveModal.tsx         | 280 +++++------
 .../src/dashboard/containers/DashboardPage.tsx     |  29 +-
 .../src/dashboard/reducers/dashboardInfo.js        |   7 +
 superset-frontend/src/dashboard/types.ts           |   6 +
 .../src/explore/components/SaveModal.tsx           |   7 +-
 .../src/features/annotations/AnnotationModal.tsx   |  10 +-
 .../databases/DatabaseModal/ExtraOptions.tsx       |  29 ++
 .../databases/DatabaseModal/SSHTunnelForm.tsx      |   2 +-
 .../src/features/databases/DatabaseModal/styles.ts |   3 +-
 .../UploadDataModel/UploadDataModal.test.tsx       |  26 +-
 superset-frontend/src/features/home/RightMenu.tsx  |  24 +-
 .../src/features/themes/ThemeModal.test.tsx        | 286 +++++++++++
 .../src/features/themes/ThemeModal.tsx             | 414 ++++++++++++++++
 .../src/features/{cssTemplates => themes}/types.ts |   8 +-
 .../src/pages/ThemeList/ThemeList.test.tsx         | 201 ++++++++
 superset-frontend/src/pages/ThemeList/index.tsx    | 524 ++++++++++++++++++++
 superset-frontend/src/theme/ThemeController.ts     | 260 +++++++++-
 superset-frontend/src/theme/ThemeProvider.tsx      |  66 ++-
 superset-frontend/src/types/Dashboard.ts           |   5 +
 superset-frontend/src/views/CRUD/types.ts          |   3 +-
 superset-frontend/src/views/routes.tsx             |   8 +
 .../theme}/__init__.py                             |   0
 superset/commands/theme/delete.py                  | 116 +++++
 .../commands/{security => theme}/exceptions.py     |  18 +-
 superset/commands/theme/export.py                  |  75 +++
 superset/commands/theme/import_themes.py           |  85 ++++
 .../theme/importers}/__init__.py                   |   0
 .../{chart => theme}/importers/dispatcher.py       |  11 +-
 superset/commands/theme/seed.py                    | 108 +++++
 .../ssh_tunnel/delete.py => theme/update.py}       |  42 +-
 superset/config.py                                 |  40 +-
 superset/daos/{security.py => theme.py}            |  14 +-
 superset/dashboards/api.py                         |   1 +
 superset/dashboards/schemas.py                     |  13 +
 superset/initialization/__init__.py                |  22 +
 ...=> 2025-07-15_16-40_3fd555e76e3d_theme_crud.py} |  66 ++-
 ...d1fb11291f2_add_theme_id_to_dashboard_model.py} |  42 +-
 superset/models/core.py                            |  12 +
 superset/models/dashboard.py                       |   3 +
 superset/themes/api.py                             | 534 +++++++++++++++++++++
 superset/{css_templates => themes}/filters.py      |  10 +-
 superset/themes/schemas.py                         |  88 ++++
 superset/views/base.py                             |  19 +-
 superset/views/{css_templates.py => themes.py}     |   7 +-
 tests/integration_tests/base_tests.py              |  17 +-
 tests/integration_tests/dashboards/api_tests.py    |  33 +-
 .../integration_tests/dashboards/commands_tests.py |   4 +-
 .../dashboards/test_theme_integration.py           | 361 ++++++++++++++
 .../integration_tests/themes}/__init__.py          |   0
 .../integration_tests/themes/api_endpoints_test.py | 322 +++++++++++++
 tests/integration_tests/themes/api_tests.py        | 398 +++++++++++++++
 .../unit_tests/themes}/__init__.py                 |   0
 tests/unit_tests/themes/api_test.py                | 119 +++++
 tests/unit_tests/themes/commands_test.py           | 229 +++++++++
 tests/unit_tests/themes/dao_test.py                |  56 +++
 tests/unit_tests/themes/model_test.py              |  53 ++
 tests/unit_tests/themes/test_utils.py              |   1 +
 96 files changed, 6026 insertions(+), 958 deletions(-)
 create mode 100644 superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/useJsonValidation.test.ts
 create mode 100644 superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/useJsonValidation.ts
 delete mode 100644 superset-frontend/packages/superset-ui-core/src/components/ThemeEditor/index.tsx
 create mode 100644 superset-frontend/packages/superset-ui-core/src/theme/utils/themeUtils.test.ts
 create mode 100644 superset-frontend/packages/superset-ui-core/src/theme/utils/themeUtils.ts
 create mode 100644 superset-frontend/src/components/CrudThemeProvider.tsx
 create mode 100644 superset-frontend/src/features/themes/ThemeModal.test.tsx
 create mode 100644 superset-frontend/src/features/themes/ThemeModal.tsx
 copy superset-frontend/src/features/{cssTemplates => themes}/types.ts (89%)
 create mode 100644 superset-frontend/src/pages/ThemeList/ThemeList.test.tsx
 create mode 100644 superset-frontend/src/pages/ThemeList/index.tsx
 copy superset/{advanced_data_type => commands/theme}/__init__.py (100%)
 create mode 100644 superset/commands/theme/delete.py
 copy superset/commands/{security => theme}/exceptions.py (71%)
 create mode 100644 superset/commands/theme/export.py
 create mode 100644 superset/commands/theme/import_themes.py
 copy superset/{advanced_data_type => commands/theme/importers}/__init__.py (100%)
 copy superset/commands/{chart => theme}/importers/dispatcher.py (90%)
 create mode 100644 superset/commands/theme/seed.py
 copy superset/commands/{database/ssh_tunnel/delete.py => theme/update.py} (54%)
 copy superset/daos/{security.py => theme.py} (69%)
 copy superset/migrations/versions/{2022-03-04_09-59_6766938c6065_add_key_value_store.py => 2025-07-15_16-40_3fd555e76e3d_theme_crud.py} (54%)
 copy superset/migrations/versions/{2024-05-01_10-52_58d051681a3b_add_catalog_perm_to_tables.py => 2025-07-15_18-41_cd1fb11291f2_add_theme_id_to_dashboard_model.py} (55%)
 create mode 100644 superset/themes/api.py
 copy superset/{css_templates => themes}/filters.py (80%)
 create mode 100644 superset/themes/schemas.py
 copy superset/views/{css_templates.py => themes.py} (89%)
 create mode 100644 tests/integration_tests/dashboards/test_theme_integration.py
 copy {superset/advanced_data_type => tests/integration_tests/themes}/__init__.py (100%)
 create mode 100644 tests/integration_tests/themes/api_endpoints_test.py
 create mode 100644 tests/integration_tests/themes/api_tests.py
 copy {superset/advanced_data_type => tests/unit_tests/themes}/__init__.py (100%)
 create mode 100644 tests/unit_tests/themes/api_test.py
 create mode 100644 tests/unit_tests/themes/commands_test.py
 create mode 100644 tests/unit_tests/themes/dao_test.py
 create mode 100644 tests/unit_tests/themes/model_test.py