[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #989: [HUDI-312] Disable embedded timeline server to mitigate integration test hanging issue

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #989: [HUDI-312] Disable embedded timeline server to mitigate integration test hanging issue
URL: https://github.com/apache/incubator-hudi/pull/989#discussion_r341534914
 
 

 ##########
 File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestHoodieDemo.java
 ##########
 @@ -88,8 +88,9 @@ public void testDemo() throws Exception {
   }
 
   private void setupDemo() throws Exception {
-    List<String> cmds = new ImmutableList.Builder<String>().add("hdfs dfsadmin -safemode wait") // handle NN going into
-                                                                                                // safe mode at times
+    List<String> cmds = new ImmutableList.Builder<String>()
+        .add("hdfs dfsadmin -safemode wait") // handle NN going into safe mode at times
 
 Review comment:
   Could we keep hdfs data within the container itself? instead of formatting.. This adds more steps to the demo when trying by hand also.. more chances of encountering some issue with hdfs itself.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services