You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/09/23 06:01:39 UTC
[PR] CAMEL-24916: simple - a dot reads a Map key when there is no such method [camel]
davsclaus opened a new pull request, #26757:
URL: https://github.com/apache/camel/pull/26757
`${body.sku}` on a map body threw `Method with name: sku not found on bean: {sku=CAMEL-MUG, qty=42}`. It is the loudest runtime failure in the AI route benchmark β 3582 occurrences in one 5-run series, more than every other runtime error together β and a frequent question, because jq, JavaScript and Groovy all read a map with a dot.
A map now answers the key when it has no method of that name:
```
${body.sku} // the sku entry, the same value ${body[sku]} gives
```
The change is additive β only the path that throws today can now return a value:
- **a method still wins**: `${body.size}` on a `Map` calls `size()` exactly as before, so nothing that works today changes
- **an unknown name still fails**: the key must be present, so a misspelled field is still reported with the existing hint rather than silently answered with null
- only a `MethodNotFoundException` triggers it, so a method that exists and throws is still a real error
Tests in `SimpleSyntaxHintsTest`: the dot reads the key, a nested map reads through (`${body.item.sku}`), `size` still calls the method, and a missing key still carries the hint. `*Simple*Test` (615), `*Bean*Test` (481), `*Ognl*Test` (18) and the camel-bean module suite are green. Docs and the 4.23 upgrade guide updated.
π€ Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01Bp3538HRBPMQkb5ta9xRaj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24916: simple - a dot reads a Map key when there is no such method [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26757:
URL: https://github.com/apache/camel/pull/26757#issuecomment-5789922442
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24916: simple - a dot reads a Map key when there is no such method [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26757:
URL: https://github.com/apache/camel/pull/26757#issuecomment-5790025321
<!-- regen-patch -->
### :warning: Generated files are out of date
The [CI build](https://github.com/apache/camel/actions/runs/35824879085) regenerated files that are not committed on this PR.
If *Allow edits from maintainers* is enabled, a maintainer bot will automatically
push a "Regen" commit to this branch shortly.
Otherwise, you can apply the patch manually β the missing changes are available
as the `regen-patch` artifact of that run:
```bash
gh pr checkout 26757 --repo apache/camel
gh run download 35824879085 --repo apache/camel -n regen-patch
git apply --index regen.patch && rm regen.patch pr-number
git commit -m "Regen" && git push
```
Alternatively, run `./etc/scripts/regen.sh` locally and commit the resulting changes.
If the patch does not apply cleanly, update the branch from the base branch first β
the patch was generated against the merge with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24916: simple - a dot reads a Map key when there is no such method [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26757:
URL: https://github.com/apache/camel/pull/26757#issuecomment-5790451426
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `catalog/camel-catalog`
- `components/camel-bean`
- `core/camel-core-languages`
- `core/camel-core`
- `docs`
> :information_source: Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the `test-dependents` label to force testing all dependents.
---
<details><summary>:microscope: Scalpel shadow comparison β Scalpel: 482 of 693 tested, 26 compile-only β current: 484 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **510 affected modules** (current approach: 484).
**Skip-tests mode would test 482 modules** (5 direct + 479 downstream), **skip tests for 26** (generated code, meta-modules)
<details><summary>:warning: Modules only in Scalpel (28)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-salesforce-maven-plugin`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `docs`
- `dummy-component`
</details>
<details><summary>Modules only in current approach (2)</summary>
- `camel-google-common`
- `camel-test-infra-core`
</details>
<details><summary>Modules Scalpel would test (482)</summary>
- `archetypes` β downstream of org.apache.camel:camel-test-junit6
- `camel-a2a` β downstream of org.apache.camel:camel-core-languages
- `camel-activemq` β downstream of org.apache.camel:camel-jms
- `camel-activemq6` β downstream of org.apache.camel:camel-jms
- `camel-ai-observability` β downstream of org.apache.camel:camel-test-junit6
- `camel-ai-observability-api` β downstream of org.apache.camel:camel-test-junit6
- `camel-ai-resource` β downstream of org.apache.camel:camel-test-junit6
- `camel-ai-tool` β downstream of org.apache.camel:camel-test-junit6
- `camel-alibaba-eventbridge` β downstream of org.apache.camel:camel-test-junit6
- `camel-alibaba-fc` β downstream of org.apache.camel:camel-test-junit6
- `camel-alibaba-kms` β downstream of org.apache.camel:camel-test-junit6
- `camel-alibaba-mns` β downstream of org.apache.camel:camel-test-junit6
- `camel-alibaba-oss` β downstream of org.apache.camel:camel-test-junit6
- `camel-alibaba-ots` β downstream of org.apache.camel:camel-test-junit6
- `camel-alibaba-sls` β downstream of org.apache.camel:camel-test-junit6
- `camel-alibaba-sms` β downstream of org.apache.camel:camel-test-junit6
- `camel-amqp` β downstream of org.apache.camel:camel-test-junit6
- `camel-api-component-maven-plugin` β downstream of org.apache.camel:camel-test-junit6
- `camel-arangodb` β downstream of org.apache.camel:camel-test-junit6
- `camel-archetype-api-component` β downstream of org.apache.camel:camel-test-junit6
- `camel-archetype-component` β downstream of org.apache.camel:camel-test-junit6
- `camel-archetype-dataformat` β downstream of org.apache.camel:camel-test-junit6
- `camel-archetype-java` β downstream of org.apache.camel:camel-test-junit6
- `camel-archetype-main` β downstream of org.apache.camel:camel-test-junit6
- `camel-as2` β downstream of org.apache.camel:camel-test-junit6
- `camel-as2-api` β downstream of org.apache.camel:camel-test-junit6
- `camel-asn1` β downstream of org.apache.camel:camel-test-junit6
- `camel-asterisk` β downstream of org.apache.camel:camel-test-junit6
- `camel-atmosphere-websocket` β downstream of org.apache.camel:camel-test-junit6
- `camel-atom` β downstream of org.apache.camel:camel-test-junit6
- `camel-attachments` β downstream of org.apache.camel:camel-bean
- `camel-avro` β downstream of org.apache.camel:camel-test-junit6
- `camel-avro-rpc` β downstream of org.apache.camel:camel-test-junit6
- `camel-aws-bedrock` β downstream of org.apache.camel:camel-base64
- `camel-aws-cloudtrail` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws-config` β downstream of org.apache.camel:camel-test-junit6
- `camel-aws-parameter-store` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws-secrets-manager` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws-security-hub` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-athena` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-comprehend` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-cw` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-ddb` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-ec2` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-ecs` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-eks` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-eventbridge` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-iam` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-kinesis` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-kms` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-lambda` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-mq` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-msk` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-polly` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-redshift` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-rekognition` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-s3` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-s3-vectors` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-ses` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-sns` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-sqs` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-step-functions` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-sts` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-textract` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-timestream` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-aws2-transcribe` β downstream of org.apache.camel:camel-test-junit6
- `camel-aws2-translate` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-azure-cosmosdb` β downstream of org.apache.camel:camel-test-junit6
- `camel-azure-eventgrid` β downstream of org.apache.camel:camel-test-junit6
- `camel-azure-eventhubs` β downstream of org.apache.camel:camel-test-junit6
- `camel-azure-files` β downstream of org.apache.camel:camel-test-junit6
- `camel-azure-functions` β downstream of org.apache.camel:camel-test-junit6
- `camel-azure-key-vault` β downstream of org.apache.camel:camel-test-junit6
- `camel-azure-schema-registry` β downstream of org.apache.camel:camel-test-junit6
- `camel-azure-servicebus` β downstream of org.apache.camel:camel-test-junit6
- `camel-azure-storage-blob` β downstream of org.apache.camel:camel-test-junit6
- `camel-azure-storage-datalake` β downstream of org.apache.camel:camel-test-junit6
- `camel-azure-storage-queue` β downstream of org.apache.camel:camel-test-junit6
- `camel-barcode` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-base64` β downstream of org.apache.camel:camel-core-languages
- `camel-bean` β components/camel-bean/src/main/java/org/apache/camel/language/bean/BeanExpression.java
- `camel-bean-validator` β downstream of org.apache.camel:camel-test-junit6
- `camel-beanio` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-bindy` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-bonita` β downstream of org.apache.camel:camel-test-junit6
- `camel-box` β downstream of org.apache.camel:camel-test-junit6
- `camel-braintree` β downstream of org.apache.camel:camel-test-junit6
- `camel-caffeine` β downstream of org.apache.camel:camel-test-junit6
- `camel-camunda` β downstream of org.apache.camel:camel-test-junit6
- `camel-cassandraql` β downstream of org.apache.camel:camel-test-junit6
- `camel-catalog` β catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/docs/simple-ognl.adoc
- `camel-cbor` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-chatscript` β downstream of org.apache.camel:camel-test-junit6
- `camel-chunk` β downstream of org.apache.camel:camel-test-junit6
- `camel-cli-connector` β downstream of org.apache.camel:camel-management
- `camel-cli-debug` β downstream of org.apache.camel:camel-cli-connector
- `camel-clickhouse` β downstream of org.apache.camel:camel-test-junit6
- `camel-clickup` β downstream of org.apache.camel:camel-test-junit6
- `camel-cloudevents` β downstream of org.apache.camel:camel-test-junit6
- `camel-cm-sms` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-coap` β downstream of org.apache.camel:camel-test-junit6
- `camel-cometd` β downstream of org.apache.camel:camel-test-junit6
- `camel-console` β downstream of org.apache.camel:camel-core
- `camel-consul` β downstream of org.apache.camel:camel-bean
- `camel-core` β core/camel-core/src/test/java/org/apache/camel/language/simple/SimpleSyntaxHintsTest.java
- `camel-core-all` β downstream of org.apache.camel:camel-core-languages
- `camel-core-languages` β core/camel-core-languages/src/main/docs/modules/languages/pages/simple-ognl.adoc
- `camel-couchbase` β downstream of org.apache.camel:camel-test-junit6
- `camel-couchdb` β downstream of org.apache.camel:camel-test-junit6
- `camel-cron` β downstream of org.apache.camel:camel-test-junit6
- `camel-crypto` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-crypto-pgp` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-csv` β downstream of org.apache.camel:camel-main
- `camel-cxf-common` β downstream of org.apache.camel:camel-test-junit6
- `camel-cxf-rest` β downstream of org.apache.camel:camel-test-junit6
- `camel-cxf-soap` β downstream of org.apache.camel:camel-test-junit6
- `camel-cxf-spring-common` β downstream of org.apache.camel:camel-spring-xml
- `camel-cxf-spring-rest` β downstream of org.apache.camel:camel-spring-xml
- `camel-cxf-spring-soap` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-cxf-spring-transport` β downstream of org.apache.camel:camel-test-junit6
- `camel-cxf-transport` β downstream of org.apache.camel:camel-test-junit6
- `camel-cyberark-vault` β downstream of org.apache.camel:camel-test-junit6
- `camel-dapr` β downstream of org.apache.camel:camel-test-junit6
- `camel-datasonnet` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-debezium-common` β downstream of org.apache.camel:camel-test-junit6
- `camel-debezium-db2` β downstream of org.apache.camel:camel-test-junit6
- `camel-debezium-maven-plugin` β downstream of org.apache.camel:camel-test-junit6
- `camel-debezium-mongodb` β downstream of org.apache.camel:camel-test-junit6
- `camel-debezium-mysql` β downstream of org.apache.camel:camel-test-junit6
- `camel-debezium-oracle` β downstream of org.apache.camel:camel-test-junit6
- `camel-debezium-postgres` β downstream of org.apache.camel:camel-test-junit6
- `camel-debezium-sqlserver` β downstream of org.apache.camel:camel-test-junit6
- `camel-debug` β downstream of org.apache.camel:camel-management
- `camel-dfdl` β downstream of org.apache.camel:camel-test-junit6
- `camel-dhis2` β downstream of org.apache.camel:camel-test-junit6
- `camel-dhis2-api` β downstream of org.apache.camel:camel-test-junit6
- `camel-dhis2-parent` β downstream of org.apache.camel:camel-test-junit6
- `camel-diagram` β downstream of org.apache.camel:camel-management
- `camel-disruptor` β downstream of org.apache.camel:camel-test-junit6
- `camel-djl` β downstream of org.apache.camel:camel-test-junit6
- `camel-dns` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-docker` β downstream of org.apache.camel:camel-test-junit6
- `camel-docling` β downstream of org.apache.camel:camel-test-junit6
- `camel-drill` β downstream of org.apache.camel:camel-test-junit6
- `camel-dropbox` β downstream of org.apache.camel:camel-test-junit6
- `camel-dsl-modeline` β downstream of org.apache.camel:camel-test-junit6
- `camel-duckdb` β downstream of org.apache.camel:camel-test-junit6
- `camel-dynamic-router` β downstream of org.apache.camel:camel-management
- `camel-ehcache` β downstream of org.apache.camel:camel-test-junit6
- `camel-elasticsearch` β downstream of org.apache.camel:camel-test-junit6
- `camel-elasticsearch-rest-client` β downstream of org.apache.camel:camel-test-junit6
- `camel-event` β downstream of org.apache.camel:camel-test-junit6
- `camel-exec` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-fastjson` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-fhir` β downstream of org.apache.camel:camel-test-junit6
- `camel-file-watch` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-flatpack` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-flink` β downstream of org.apache.camel:camel-test-junit6
- `camel-flowable` β downstream of org.apache.camel:camel-test-junit6
- `camel-fop` β downstream of org.apache.camel:camel-test-junit6
- `camel-fory` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-freemarker` β downstream of org.apache.camel:camel-management
- `camel-ftp` β downstream of org.apache.camel:camel-core-languages
- `camel-geocoder` β downstream of org.apache.camel:camel-test-junit6
- `camel-git` β downstream of org.apache.camel:camel-test-junit6
- `camel-github2` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-bigquery` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-calendar` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-drive` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-firestore` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-functions` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-mail` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-pubsub` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-secret-manager` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-sheets` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-speech-to-text` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-storage` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-text-to-speech` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-vertexai` β downstream of org.apache.camel:camel-test-junit6
- `camel-google-vision` β downstream of org.apache.camel:camel-test-junit6
- `camel-graphql` β downstream of org.apache.camel:camel-test-junit6
- `camel-grok` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-groovy` β downstream of org.apache.camel:camel-main
- `camel-grpc` β downstream of org.apache.camel:camel-test-junit6
- `camel-gson` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-hashicorp-vault` β downstream of org.apache.camel:camel-test-junit6
- `camel-hazelcast` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-hivemq` β downstream of org.apache.camel:camel-test-junit6
- `camel-hl7` β downstream of org.apache.camel:camel-test-junit6
- `camel-http` β downstream of org.apache.camel:camel-management
- `camel-http-base` β downstream of org.apache.camel:camel-test-junit6
- `camel-http-common` β downstream of org.apache.camel:camel-test-junit6
- `camel-huaweicloud-dms` β downstream of org.apache.camel:camel-test-junit6
- `camel-huaweicloud-frs` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-huaweicloud-functiongraph` β downstream of org.apache.camel:camel-test-junit6
- `camel-huaweicloud-iam` β downstream of org.apache.camel:camel-test-junit6
- `camel-huaweicloud-imagerecognition` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-huaweicloud-obs` β downstream of org.apache.camel:camel-test-junit6
- `camel-huaweicloud-smn` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-huggingface` β downstream of org.apache.camel:camel-test-junit6
- `camel-ibm-cos` β downstream of org.apache.camel:camel-test-junit6
- `camel-ibm-secrets-manager` β downstream of org.apache.camel:camel-test-junit6
- `camel-ibm-watson-discovery` β downstream of org.apache.camel:camel-test-junit6
- `camel-ibm-watson-language` β downstream of org.apache.camel:camel-test-junit6
- `camel-ibm-watson-speech-to-text` β downstream of org.apache.camel:camel-test-junit6
- `camel-ibm-watson-text-to-speech` β downstream of org.apache.camel:camel-test-junit6
- `camel-ibm-watsonx-ai` β downstream of org.apache.camel:camel-test-junit6
- `camel-ibm-watsonx-data` β downstream of org.apache.camel:camel-test-junit6
- `camel-ical` β downstream of org.apache.camel:camel-test-junit6
- `camel-iggy` β downstream of org.apache.camel:camel-test-junit6
- `camel-ignite` β downstream of org.apache.camel:camel-test-junit6
- `camel-infinispan` β downstream of org.apache.camel:camel-test-junit6
- `camel-infinispan-common` β downstream of org.apache.camel:camel-test-junit6
- `camel-infinispan-embedded` β downstream of org.apache.camel:camel-test-junit6
- `camel-influxdb` β downstream of org.apache.camel:camel-test-junit6
- `camel-influxdb2` β downstream of org.apache.camel:camel-test-junit6
- `camel-iso8583` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-jackson` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-jackson-avro` β downstream of org.apache.camel:camel-test-junit6
- `camel-jackson-protobuf` β downstream of org.apache.camel:camel-test-junit6
- `camel-jackson3` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-jackson3-avro` β downstream of org.apache.camel:camel-test-junit6
- `camel-jackson3-protobuf` β downstream of org.apache.camel:camel-test-junit6
- `camel-jackson3xml` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-jacksonxml` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-jactl` β downstream of org.apache.camel:camel-test-junit6
- `camel-jandex` β downstream of org.apache.camel:camel-test-junit6
- `camel-jasypt` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-java-joor-dsl` β downstream of org.apache.camel:camel-bean
- `camel-javascript` β downstream of org.apache.camel:camel-test-junit6
- `camel-jaxb` β downstream of org.apache.camel:camel-test-junit6
- `camel-jbang-console` β downstream of org.apache.camel:camel-management
- `camel-jbang-mcp` β downstream of org.apache.camel:camel-catalog
- `camel-jbang-plugin-mcp` β downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-route-parser` β downstream of org.apache.camel:camel-route-parser
- `camel-jbang-plugin-tui` β downstream of org.apache.camel:camel-catalog
- `camel-jbang-plugin-validate` β downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-jcache` β downstream of org.apache.camel:camel-core-languages
- `camel-jcr` β downstream of org.apache.camel:camel-test-junit6
- `camel-jdbc` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-jetty` β downstream of org.apache.camel:camel-management
- `camel-jetty-common` β downstream of org.apache.camel:camel-spring-xml
- `camel-jev` β downstream of org.apache.camel:camel-core-languages
- `camel-jfr` β downstream of org.apache.camel:camel-test-junit6
- `camel-jgroups` β downstream of org.apache.camel:camel-test-junit6
- `camel-jgroups-raft` β downstream of org.apache.camel:camel-test-junit6
- `camel-jira` β downstream of org.apache.camel:camel-test-junit6
- `camel-jms` β downstream of org.apache.camel:camel-management
- `camel-jmx` β downstream of org.apache.camel:camel-management
- `camel-jolt` β downstream of org.apache.camel:camel-test-junit6
- `camel-jooq` β downstream of org.apache.camel:camel-test-junit6
- `camel-joor` β downstream of org.apache.camel:camel-test-junit6
- `camel-jpa` β downstream of org.apache.camel:camel-core-languages
- `camel-jq` β downstream of org.apache.camel:camel-test-junit6
- `camel-jsch` β downstream of org.apache.camel:camel-test-junit6
- `camel-jslt` β downstream of org.apache.camel:camel-test-junit6
- `camel-json-validator` β downstream of org.apache.camel:camel-test-junit6
- `camel-jsonapi` β downstream of org.apache.camel:camel-test-junit6
- `camel-jsonata` β downstream of org.apache.camel:camel-test-junit6
- `camel-jsonb` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-jsonpath` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-jsoup` β downstream of org.apache.camel:camel-core-languages
- `camel-jt400` β downstream of org.apache.camel:camel-test-junit6
- `camel-jta` β downstream of org.apache.camel:camel-sql
- `camel-jte` β downstream of org.apache.camel:camel-test-junit6
- `camel-kafka` β downstream of org.apache.camel:camel-test-junit6
- `camel-kamelet` β downstream of org.apache.camel:camel-management
- `camel-kamelet-main-support` β downstream of org.apache.camel:camel-main
- `camel-keycloak` β downstream of org.apache.camel:camel-test-junit6
- `camel-knative` β downstream of org.apache.camel:camel-test-junit6
- `camel-knative-api` β downstream of org.apache.camel:camel-test-junit6
- `camel-knative-http` β downstream of org.apache.camel:camel-test-junit6
- `camel-kserve` β downstream of org.apache.camel:camel-test-junit6
- `camel-kubernetes` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-kudu` β downstream of org.apache.camel:camel-test-junit6
- `camel-langchain4j-agent` β downstream of org.apache.camel:camel-test-junit6
- `camel-langchain4j-chat` β downstream of org.apache.camel:camel-test-junit6
- `camel-langchain4j-core` β downstream of org.apache.camel:camel-test-junit6
- `camel-langchain4j-embeddings` β downstream of org.apache.camel:camel-test-junit6
- `camel-langchain4j-embeddingstore` β downstream of org.apache.camel:camel-test-junit6
- `camel-langchain4j-ingest` β downstream of org.apache.camel:camel-test-junit6
- `camel-langchain4j-tokenizer` β downstream of org.apache.camel:camel-test-junit6
- `camel-langchain4j-web-search` β downstream of org.apache.camel:camel-test-junit6
- `camel-launcher-container` β downstream of org.apache.camel:camel-launcher
- `camel-ldap` β downstream of org.apache.camel:camel-test-junit6
- `camel-ldif` β downstream of org.apache.camel:camel-test-junit6
- `camel-lra` β downstream of org.apache.camel:camel-test-junit6
- `camel-lucene` β downstream of org.apache.camel:camel-test-junit6
- `camel-lumberjack` β downstream of org.apache.camel:camel-test-junit6
- `camel-lzf` β downstream of org.apache.camel:camel-test-junit6
- `camel-mail` β downstream of org.apache.camel:camel-attachments
- `camel-mail-microsoft-oauth` β downstream of org.apache.camel:camel-mail
- `camel-main` β downstream of org.apache.camel:camel-bean
- `camel-management` β downstream of org.apache.camel:camel-bean
- `camel-mapstruct` β downstream of org.apache.camel:camel-test-junit6
- `camel-master` β downstream of org.apache.camel:camel-test-junit6
- `camel-maven-plugin` β downstream of org.apache.camel:camel-spring-main
- `camel-mcp-server` β downstream of org.apache.camel:camel-test-junit6
- `camel-mcp-server-api` β downstream of org.apache.camel:camel-test-junit6
- `camel-mdc` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-metrics` β downstream of org.apache.camel:camel-management
- `camel-micrometer` β downstream of org.apache.camel:camel-management
- `camel-micrometer-observability` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-micrometer-prometheus` β downstream of org.apache.camel:camel-micrometer
- `camel-microprofile-config` β downstream of org.apache.camel:camel-test-junit6
- `camel-microprofile-fault-tolerance` β downstream of org.apache.camel:camel-management
- `camel-microprofile-health` β downstream of org.apache.camel:camel-test-junit6
- `camel-milo` β downstream of org.apache.camel:camel-test-junit6
- `camel-milvus` β downstream of org.apache.camel:camel-test-junit6
- `camel-mina` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-mina-sftp` β downstream of org.apache.camel:camel-core-languages
- `camel-minio` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-mllp` β downstream of org.apache.camel:camel-test-junit6
- `camel-mongodb` β downstream of org.apache.camel:camel-test-junit6
- `camel-mongodb-gridfs` β downstream of org.apache.camel:camel-test-junit6
- `camel-mustache` β downstream of org.apache.camel:camel-test-junit6
- `camel-mvel` β downstream of org.apache.camel:camel-test-junit6
- `camel-mybatis` β downstream of org.apache.camel:camel-bean
- `camel-nats` β downstream of org.apache.camel:camel-test-junit6
- `camel-neo4j` β downstream of org.apache.camel:camel-test-junit6
- `camel-netty` β downstream of org.apache.camel:camel-management
- `camel-netty-http` β downstream of org.apache.camel:camel-management
- `camel-oaipmh` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-oauth` β downstream of org.apache.camel:camel-test-junit6
- `camel-observability-services` β downstream of org.apache.camel:camel-management
- `camel-observation` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-ocsf` β downstream of org.apache.camel:camel-test-junit6
- `camel-ognl` β downstream of org.apache.camel:camel-test-junit6
- `camel-olingo2` β downstream of org.apache.camel:camel-test-junit6
- `camel-olingo2-api` β downstream of org.apache.camel:camel-test-junit6
- `camel-olingo4` β downstream of org.apache.camel:camel-test-junit6
- `camel-olingo4-api` β downstream of org.apache.camel:camel-test-junit6
- `camel-once` β downstream of org.apache.camel:camel-test-junit6
- `camel-opa` β downstream of org.apache.camel:camel-test-junit6
- `camel-openai` β downstream of org.apache.camel:camel-test-junit6
- `camel-openapi-java` β downstream of org.apache.camel:camel-management
- `camel-openapi-validator` β downstream of org.apache.camel:camel-test-junit6
- `camel-opensearch` β downstream of org.apache.camel:camel-test-junit6
- `camel-openstack` β downstream of org.apache.camel:camel-test-junit6
- `camel-opentelemetry` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-opentelemetry-metrics` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-opentelemetry2` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-optaplanner` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-paho` β downstream of org.apache.camel:camel-test-junit6
- `camel-paho-mqtt5` β downstream of org.apache.camel:camel-test-junit6
- `camel-parquet-avro` β downstream of org.apache.camel:camel-test-junit6
- `camel-pdf` β downstream of org.apache.camel:camel-test-junit6
- `camel-pg-replication-slot` β downstream of org.apache.camel:camel-test-junit6
- `camel-pgevent` β downstream of org.apache.camel:camel-test-junit6
- `camel-pgvector` β downstream of org.apache.camel:camel-test-junit6
- `camel-pinecone` β downstream of org.apache.camel:camel-test-junit6
- `camel-platform-http` β downstream of org.apache.camel:camel-test-junit6
- `camel-platform-http-jolokia` β downstream of org.apache.camel:camel-platform-http
- `camel-platform-http-main` β downstream of org.apache.camel:camel-test-junit6
- `camel-platform-http-vertx` β downstream of org.apache.camel:camel-management
- `camel-plc4x` β downstream of org.apache.camel:camel-test-junit6
- `camel-pqc` β downstream of org.apache.camel:camel-test-junit6
- `camel-printer` β downstream of org.apache.camel:camel-test-junit6
- `camel-protobuf` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-pubnub` β downstream of org.apache.camel:camel-test-junit6
- `camel-pulsar` β downstream of org.apache.camel:camel-test-junit6
- `camel-python` β downstream of org.apache.camel:camel-test-junit6
- `camel-python3` β downstream of org.apache.camel:camel-test-junit6
- `camel-qdrant` β downstream of org.apache.camel:camel-test-junit6
- `camel-quartz` β downstream of org.apache.camel:camel-management
- `camel-quickfix` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-quickjs` β downstream of org.apache.camel:camel-test-junit6
- `camel-reactive-streams` β downstream of org.apache.camel:camel-management
- `camel-reactor` β downstream of org.apache.camel:camel-test-junit6
- `camel-redis` β downstream of org.apache.camel:camel-test-junit6
- `camel-resilience4j` β downstream of org.apache.camel:camel-management
- `camel-resilience4j-micrometer` β downstream of org.apache.camel:camel-management
- `camel-resourceresolver-github` β downstream of org.apache.camel:camel-test-junit6
- `camel-rest` β downstream of org.apache.camel:camel-core-languages
- `camel-rest-openapi` β downstream of org.apache.camel:camel-test-junit6
- `camel-rest-postman` β downstream of org.apache.camel:camel-test-junit6
- `camel-restdsl-openapi-plugin` β downstream of org.apache.camel:camel-openapi-java
- `camel-robotframework` β downstream of org.apache.camel:camel-test-junit6
- `camel-rocketmq` β downstream of org.apache.camel:camel-test-junit6
- `camel-rss` β downstream of org.apache.camel:camel-test-junit6
- `camel-rxjava` β downstream of org.apache.camel:camel-test-junit6
- `camel-salesforce` β downstream of org.apache.camel:camel-test-junit6
- `camel-salesforce-codegen` β downstream of org.apache.camel:camel-salesforce
- `camel-sap-netweaver` β downstream of org.apache.camel:camel-test-junit6
- `camel-saxon` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-schematron` β downstream of org.apache.camel:camel-test-junit6
- `camel-servicenow` β downstream of org.apache.camel:camel-test-junit6
- `camel-servicenow-maven-plugin` β downstream of org.apache.camel:camel-test-junit6
- `camel-servlet` β downstream of org.apache.camel:camel-management
- `camel-shell` β downstream of org.apache.camel:camel-test-junit5
- `camel-shiro` β downstream of org.apache.camel:camel-test-junit6
- `camel-sjms` β downstream of org.apache.camel:camel-test-junit6
- `camel-sjms2` β downstream of org.apache.camel:camel-test-junit6
- `camel-slack` β downstream of org.apache.camel:camel-test-junit6
- `camel-smb` β downstream of org.apache.camel:camel-test-junit6
- `camel-smooks` β downstream of org.apache.camel:camel-test-junit6
- `camel-smpp` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-snakeyaml` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-snmp` β downstream of org.apache.camel:camel-test-junit6
- `camel-soap` β downstream of org.apache.camel:camel-test-junit6
- `camel-solr` β downstream of org.apache.camel:camel-test-junit6
- `camel-spiffe` β downstream of org.apache.camel:camel-test-junit6
- `camel-splunk-hec` β downstream of org.apache.camel:camel-test-junit6
- `camel-spring` β downstream of org.apache.camel:camel-cron
- `camel-spring-ai-chat` β downstream of org.apache.camel:camel-test-junit6
- `camel-spring-ai-embeddings` β downstream of org.apache.camel:camel-test-junit6
- `camel-spring-ai-image` β downstream of org.apache.camel:camel-test-junit6
- `camel-spring-ai-vector-store` β downstream of org.apache.camel:camel-test-junit6
- `camel-spring-batch` β downstream of org.apache.camel:camel-test-junit6
- `camel-spring-cloud-config` β downstream of org.apache.camel:camel-test-junit6
- `camel-spring-jdbc` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-spring-ldap` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-spring-main` β downstream of org.apache.camel:camel-main
- `camel-spring-rabbitmq` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-spring-redis` β downstream of org.apache.camel:camel-test-junit6
- `camel-spring-security` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-spring-ws` β downstream of org.apache.camel:camel-attachments
- `camel-spring-xml` β downstream of org.apache.camel:camel-bean
- `camel-sql` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-ssh` β downstream of org.apache.camel:camel-test-junit6
- `camel-state-store` β downstream of org.apache.camel:camel-test-main-junit5
- `camel-stax` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-stitch` β downstream of org.apache.camel:camel-test-junit6
- `camel-stream` β downstream of org.apache.camel:camel-test-junit6
- `camel-streamcaching-test` β downstream of org.apache.camel:camel-test-junit6
- `camel-stringtemplate` β downstream of org.apache.camel:camel-management
- `camel-stripe` β downstream of org.apache.camel:camel-test-junit6
- `camel-swift` β downstream of org.apache.camel:camel-test-junit6
- `camel-syslog` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-tahu` β downstream of org.apache.camel:camel-test-junit6
- `camel-tarfile` β downstream of org.apache.camel:camel-test-junit6
- `camel-telegram` β downstream of org.apache.camel:camel-test-junit6
- `camel-telemetry` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-telemetry-dev` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-tensorflow-serving` β downstream of org.apache.camel:camel-test-junit6
- `camel-test-infra-all` β downstream of org.apache.camel:camel-test-infra-artemis
- `camel-test-infra-artemis` β downstream of org.apache.camel:camel-test-junit6
- `camel-test-infra-smb` β downstream of org.apache.camel:camel-test-junit6
- `camel-test-junit5` β downstream of org.apache.camel:camel-bean
- `camel-test-junit6` β downstream of org.apache.camel:camel-bean
- `camel-test-main-junit5` β downstream of org.apache.camel:camel-management
- `camel-test-main-junit6` β downstream of org.apache.camel:camel-management
- `camel-test-spring-junit5` β downstream of org.apache.camel:camel-management
- `camel-test-spring-junit6` β downstream of org.apache.camel:camel-management
- `camel-thrift` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-thymeleaf` β downstream of org.apache.camel:camel-management
- `camel-tika` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-toon` β downstream of org.apache.camel:camel-test-junit5
- `camel-tracing` β downstream of org.apache.camel:camel-test-spring-junit6
- `camel-twilio` β downstream of org.apache.camel:camel-test-junit6
- `camel-twitter` β downstream of org.apache.camel:camel-test-junit6
- `camel-ubl` β downstream of org.apache.camel:camel-test-junit5
- `camel-undertow` β downstream of org.apache.camel:camel-management
- `camel-undertow-spring-security` β downstream of org.apache.camel:camel-test-junit6
- `camel-univocity-parsers` β downstream of org.apache.camel:camel-spring-xml
- `camel-velocity` β downstream of org.apache.camel:camel-management
- `camel-vertx` β downstream of org.apache.camel:camel-test-junit6
- `camel-vertx-http` β downstream of org.apache.camel:camel-test-junit6
- `camel-vertx-websocket` β downstream of org.apache.camel:camel-test-junit6
- `camel-wasm` β downstream of org.apache.camel:camel-test-junit6
- `camel-weather` β downstream of org.apache.camel:camel-test-junit6
- `camel-weaviate` β downstream of org.apache.camel:camel-test-junit6
- `camel-web3j` β downstream of org.apache.camel:camel-test-junit6
- `camel-webhook` β downstream of org.apache.camel:camel-test-junit6
- `camel-whatsapp` β downstream of org.apache.camel:camel-test-junit6
- `camel-wordpress` β downstream of org.apache.camel:camel-test-junit6
- `camel-workday` β downstream of org.apache.camel:camel-test-junit6
- `camel-xchange` β downstream of org.apache.camel:camel-test-junit6
- `camel-xj` β downstream of org.apache.camel:camel-test-junit6
- `camel-xml-io-dsl` β downstream of org.apache.camel:camel-bean
- `camel-xml-jaxb-dsl` β downstream of org.apache.camel:camel-bean
- `camel-xml-jaxb-dsl-test-definition` β downstream of org.apache.camel:camel-bean
- `camel-xml-jaxb-dsl-test-spring` β downstream of org.apache.camel:camel-bean
- `camel-xmlsecurity` β downstream of org.apache.camel:camel-test-junit6
- `camel-xmpp` β downstream of org.apache.camel:camel-test-junit6
- `camel-xslt-saxon` β downstream of org.apache.camel:camel-spring-xml
- `camel-yaml-dsl-validator` β downstream of org.apache.camel:camel-catalog
- `camel-yaml-dsl-validator-maven-plugin` β downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-zendesk` β downstream of org.apache.camel:camel-test-junit6
- `camel-zip-deflater` β downstream of org.apache.camel:camel-test-junit6
- `camel-zipfile` β downstream of org.apache.camel:camel-test-junit6
- `camel-zookeeper` β downstream of org.apache.camel:camel-bean
- `camel-zookeeper-master` β downstream of org.apache.camel:camel-test-junit6
- `docs` β docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc
</details>
<details><summary>Modules with tests skipped (26)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog-console`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-salesforce-maven-plugin`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `dummy-component`
</details>
> :information_source: Shadow mode β Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
:warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
- `core/camel-core`: 3 test(s) disabled on GitHub Actions
<details><summary>Build reactor β dependencies compiled but only changed modules were tested (5 modules, 1m 16s total)</summary>
**Total reactor time:** 1m 16s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: Catalog :: Camel Catalog | 31.5s | SUCCESS |
| Camel :: Docs | 24.1s | SUCCESS |
| Camel :: Bean | 11.0s | SUCCESS |
| Camel :: Core Languages | 9.0s | SUCCESS |
| Camel :: Core | n/a | |
**Top 20 slowest modules:**
- `Camel :: Catalog :: Camel Catalog` (31.5s)
- `Camel :: Docs` (24.1s)
- `Camel :: Bean` (11.0s)
- `Camel :: Core Languages` (9.0s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/35827372492)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24916: simple - a dot reads a Map key when there is no such method [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on code in PR #26757:
URL: https://github.com/apache/camel/pull/26757#discussion_r4079547634
##########
components/camel-bean/src/main/java/org/apache/camel/language/bean/BeanExpression.java:
##########
@@ -535,6 +542,40 @@ exchange, describeBean(holder, beanName, exchange),
return newResult;
}
+ /** Says that the bean is not a Map with that key, as null is a value a key can hold. */
+ private static final Object NO_SUCH_KEY = new Object();
+
+ /**
+ * The value of the key on a Map bean when the method of that name does not exist, so that ${body.sku} reads the sku
+ * of a map the way ${body[sku]} does - what a map means in jq, JavaScript and Groovy too (CAMEL-24916).
+ * <p/>
+ * A method still wins: ${body.size} on a Map calls size() as before. A name that is not a key still fails, so a
+ * misspelled field is still reported.
+ *
+ * @return the value of the key, or {@link #NO_SUCH_KEY} when this is not that case
Review Comment:
π‘ **Nit: incomplete Javadoc `@param` coverage**
The Javadoc documents `@return` but none of the four parameters. `mapValue()` is private, so this is low-stakes, but the contract of each parameter is non-obvious β particularly `cause` (why is it passed instead of inspecting `resultExchange` internally?) and `holder` (why nullable?). Add four `@param` tags before the `@return`:
```suggestion
* @param holder the bean holder; may be null (treated as no bean)
* @param exchange the current exchange, forwarded to {@link BeanHolder#getBean(Exchange)}
* @param methodName the OGNL segment that failed as a method call (i.e. the candidate key name)
* @param cause the exception thrown by the failed method invocation
* @return the value of the key, or {@link #NO_SUCH_KEY} when this is not that case
```
##########
core/camel-core/src/test/java/org/apache/camel/language/simple/SimpleSyntaxHintsTest.java:
##########
@@ -144,16 +144,42 @@ public void testOgnlRuntimeMessages() {
}
@Test
- public void testOgnlDotOnAMapSaysToUseAKey() {
+ public void testOgnlDotOnAMapReadsTheKey() {
+ // CAMEL-24916: a map has no method type, so the key is what the dot can mean
exchange.getIn().setBody(new java.util.LinkedHashMap<>(java.util.Map.of("type", "order")));
- Exception e = assertThrows(Exception.class,
- () -> context.resolveLanguage("simple").createExpression("${body.type}").evaluate(exchange,
- String.class));
- assertThat(e.getMessage()).contains("the value is a Map: a key is read with [type], as in ${body[type]}");
+ assertEquals("order", context.resolveLanguage("simple").createExpression("${body.type}").evaluate(exchange,
+ String.class));
assertEquals("order", context.resolveLanguage("simple").createExpression("${body[type]}").evaluate(exchange,
String.class));
}
+ @Test
+ public void testOgnlDotOnAMapWithoutThatKeySaysToUseAKey() {
+ exchange.getIn().setBody(new java.util.LinkedHashMap<>(java.util.Map.of("type", "order")));
+ Exception e = assertThrows(Exception.class,
+ () -> context.resolveLanguage("simple").createExpression("${body.typo}").evaluate(exchange,
+ String.class));
+ assertThat(e.getMessage()).contains("the value is a Map: a key is read with [typo], as in ${body[typo]}");
+ }
+
+ @Test
+ public void testAMethodOfAMapStillWins() {
+ exchange.getIn().setBody(new java.util.LinkedHashMap<>(java.util.Map.of("size", "not the size")));
+ assertEquals("1", context.resolveLanguage("simple").createExpression("${body.size}").evaluate(exchange,
+ String.class), "size() is a method of Map, so it still answers before the key");
+ }
+
+ @Test
+ public void testOgnlDotOnANestedMapReadsTheKey() {
+ java.util.Map<String, Object> item = new java.util.LinkedHashMap<>();
+ item.put("sku", "CAMEL-MUG");
+ java.util.Map<String, Object> body = new java.util.LinkedHashMap<>();
+ body.put("item", item);
+ exchange.getIn().setBody(body);
+ assertEquals("CAMEL-MUG", context.resolveLanguage("simple").createExpression("${body.item.sku}")
+ .evaluate(exchange, String.class));
+ }
Review Comment:
π‘ **Missing test: null-valued map entry**
The new `containsKey`/`get` path in `mapValue()` has one subtle branch not covered: a map that *has* the key but maps it to `null`. The sentinel `NO_SUCH_KEY` is needed precisely to distinguish "key absent" from "key present with value null", and the correctness of that distinction (`value != NO_SUCH_KEY` in the caller) deserves a test.
Suggested addition after `testOgnlDotOnANestedMapReadsTheKey`:
```java
@Test
public void testOgnlDotOnAMapWithNullValueReturnsNull() {
java.util.HashMap<String, Object> m = new java.util.HashMap<>();
m.put("sku", null);
exchange.getIn().setBody(m);
assertNull(context.resolveLanguage("simple").createExpression("${body.sku}").evaluate(exchange, Object.class),
"a null value is a valid map entry; the expression must return null, not throw");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24916: simple - a dot reads a Map key when there is no such method [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on code in PR #26757:
URL: https://github.com/apache/camel/pull/26757#discussion_r4079603893
##########
components/camel-bean/src/main/java/org/apache/camel/language/bean/BeanExpression.java:
##########
@@ -535,6 +542,40 @@ exchange, describeBean(holder, beanName, exchange),
return newResult;
}
+ /** Says that the bean is not a Map with that key, as null is a value a key can hold. */
+ private static final Object NO_SUCH_KEY = new Object();
+
+ /**
+ * The value of the key on a Map bean when the method of that name does not exist, so that ${body.sku} reads the sku
+ * of a map the way ${body[sku]} does - what a map means in jq, JavaScript and Groovy too (CAMEL-24916).
+ * <p/>
+ * A method still wins: ${body.size} on a Map calls size() as before. A name that is not a key still fails, so a
+ * misspelled field is still reported.
+ *
+ * @return the value of the key, or {@link #NO_SUCH_KEY} when this is not that case
Review Comment:
π‘ **[Re-raise] Javadoc `@param` tags still missing**
The prior review asked for four `@param` tags on `mapValue()`. Still absent after this push. The contract of `cause` (why pass the exception rather than inspecting `resultExchange`?) and `holder` (why nullable?) is non-obvious for future readers.
```suggestion
* @param holder the bean holder; may be null (treated as no bean)
* @param exchange the current exchange, forwarded to {@link BeanHolder#getBean(Exchange)}
* @param methodName the OGNL segment that failed as a method call (i.e. the candidate key name)
* @param cause the exception thrown by the failed method invocation
* @return the value of the key, or {@link #NO_SUCH_KEY} when this is not that case
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24916: simple - a dot reads a Map key when there is no such method [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #26757:
URL: https://github.com/apache/camel/pull/26757#discussion_r4080278787
##########
components/camel-bean/src/main/java/org/apache/camel/language/bean/BeanExpression.java:
##########
@@ -535,6 +542,40 @@ exchange, describeBean(holder, beanName, exchange),
return newResult;
}
+ /** Says that the bean is not a Map with that key, as null is a value a key can hold. */
+ private static final Object NO_SUCH_KEY = new Object();
+
+ /**
+ * The value of the key on a Map bean when the method of that name does not exist, so that ${body.sku} reads the sku
+ * of a map the way ${body[sku]} does - what a map means in jq, JavaScript and Groovy too (CAMEL-24916).
+ * <p/>
+ * A method still wins: ${body.size} on a Map calls size() as before. A name that is not a key still fails, so a
+ * misspelled field is still reported.
+ *
+ * @return the value of the key, or {@link #NO_SUCH_KEY} when this is not that case
Review Comment:
They are there β `BeanExpression.java` lines 555-559 on the branch tip (e9d45e6):
```
* @param holder the bean the OGNL step is called on; null when there is none
* @param exchange the exchange the bean is resolved against
* @param methodName the name that failed as a method call, and is tried as a key
* @param cause the failure of that call, so that only a missing method is read as a key
* @return the value of the key, or {@link #NO_SUCH_KEY} when this is not that case
```
This review looks to have run against the state before that push. To the two questions in it: `cause` is passed because the method must tell a missing method from a method that exists and threw - only `MethodNotFoundException` may be read as a key, anything else is a real error that must keep propagating. `holder` is nullable because the OGNL chain can reach a step with no bean resolved, and `getBean` is then not called at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24916: simple - a dot reads a Map key when there is no such method [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #26757:
URL: https://github.com/apache/camel/pull/26757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24916: simple - a dot reads a Map key when there is no such method [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26757:
URL: https://github.com/apache/camel/pull/26757#issuecomment-5790100118
**[Re-raise] Missing test: null-valued map entry** β still not added after this push.
The `containsKey`/`get` path in `mapValue()` correctly uses `NO_SUCH_KEY` to distinguish "key absent" from "key present with null value", but this distinction is untested. Please add after `testOgnlDotOnANestedMapReadsTheKey`:
```java
@Test
public void testOgnlDotOnAMapWithNullValueReturnsNull() {
java.util.HashMap<String, Object> m = new java.util.HashMap<>();
m.put("sku", null);
exchange.getIn().setBody(m);
assertNull(context.resolveLanguage("simple").createExpression("${body.sku}").evaluate(exchange, Object.class),
"a null value is a valid map entry; the expression must return null, not throw");
}
```
_This review was generated by an AI agent, Hermès on behalf of @gnodet._
<!-- reviewer: gnodet-bot -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24916: simple - a dot reads a Map key when there is no such method [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #26757:
URL: https://github.com/apache/camel/pull/26757#discussion_r4079655261
##########
components/camel-bean/src/main/java/org/apache/camel/language/bean/BeanExpression.java:
##########
@@ -535,6 +542,40 @@ exchange, describeBean(holder, beanName, exchange),
return newResult;
}
+ /** Says that the bean is not a Map with that key, as null is a value a key can hold. */
+ private static final Object NO_SUCH_KEY = new Object();
+
+ /**
+ * The value of the key on a Map bean when the method of that name does not exist, so that ${body.sku} reads the sku
+ * of a map the way ${body[sku]} does - what a map means in jq, JavaScript and Groovy too (CAMEL-24916).
+ * <p/>
+ * A method still wins: ${body.size} on a Map calls size() as before. A name that is not a key still fails, so a
+ * misspelled field is still reported.
+ *
+ * @return the value of the key, or {@link #NO_SUCH_KEY} when this is not that case
Review Comment:
Added the four @param tags.
##########
core/camel-core/src/test/java/org/apache/camel/language/simple/SimpleSyntaxHintsTest.java:
##########
@@ -144,16 +144,42 @@ public void testOgnlRuntimeMessages() {
}
@Test
- public void testOgnlDotOnAMapSaysToUseAKey() {
+ public void testOgnlDotOnAMapReadsTheKey() {
+ // CAMEL-24916: a map has no method type, so the key is what the dot can mean
exchange.getIn().setBody(new java.util.LinkedHashMap<>(java.util.Map.of("type", "order")));
- Exception e = assertThrows(Exception.class,
- () -> context.resolveLanguage("simple").createExpression("${body.type}").evaluate(exchange,
- String.class));
- assertThat(e.getMessage()).contains("the value is a Map: a key is read with [type], as in ${body[type]}");
+ assertEquals("order", context.resolveLanguage("simple").createExpression("${body.type}").evaluate(exchange,
+ String.class));
assertEquals("order", context.resolveLanguage("simple").createExpression("${body[type]}").evaluate(exchange,
String.class));
}
+ @Test
+ public void testOgnlDotOnAMapWithoutThatKeySaysToUseAKey() {
+ exchange.getIn().setBody(new java.util.LinkedHashMap<>(java.util.Map.of("type", "order")));
+ Exception e = assertThrows(Exception.class,
+ () -> context.resolveLanguage("simple").createExpression("${body.typo}").evaluate(exchange,
+ String.class));
+ assertThat(e.getMessage()).contains("the value is a Map: a key is read with [typo], as in ${body[typo]}");
+ }
+
+ @Test
+ public void testAMethodOfAMapStillWins() {
+ exchange.getIn().setBody(new java.util.LinkedHashMap<>(java.util.Map.of("size", "not the size")));
+ assertEquals("1", context.resolveLanguage("simple").createExpression("${body.size}").evaluate(exchange,
+ String.class), "size() is a method of Map, so it still answers before the key");
+ }
+
+ @Test
+ public void testOgnlDotOnANestedMapReadsTheKey() {
+ java.util.Map<String, Object> item = new java.util.LinkedHashMap<>();
+ item.put("sku", "CAMEL-MUG");
+ java.util.Map<String, Object> body = new java.util.LinkedHashMap<>();
+ body.put("item", item);
+ exchange.getIn().setBody(body);
+ assertEquals("CAMEL-MUG", context.resolveLanguage("simple").createExpression("${body.item.sku}")
+ .evaluate(exchange, String.class));
+ }
Review Comment:
Good catch - that is the case the sentinel exists for, and it had no test. Added `testOgnlDotOnAMapWithANullValueAnswersNull`: a map with `sku` mapped to null answers null instead of throwing, which is what tells "the key is there and holds null" apart from "there is no such key".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org