You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2021/04/28 15:23:00 UTC

[jira] [Commented] (IGNITE-14655) .NET: Do not return task from IDataStreamer.AddData method

    [ https://issues.apache.org/jira/browse/IGNITE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334802#comment-17334802 ] 

Ignite TC Bot commented on IGNITE-14655:
----------------------------------------

{panel:title=Branch: [pull/9058/head] Base: [master] : Possible Blockers (10)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Control Utility{color} [[tests 0 TIMEOUT , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=5985728]]

{color:#d04437}Basic 1{color} [[tests 0 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=5985674]]

{color:#d04437}Cache 6{color} [[tests 0 TIMEOUT , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=5985695]]

{color:#d04437}Platform .NET (Core Linux){color} [[tests 1 TC_SERVICE_MESSAGE |https://ci.ignite.apache.org/viewLog.html?buildId=5985710]]
* dll: ContinuousQueryTest.TestIncludeExpiredIsFalseByDefaultAndExpiredEventsAreSkipped - Test has low fail rate in base branch 0,0% and is not flaky

{color:#d04437}Java Client{color} [[tests 0 TIMEOUT , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=5985653]]

{color:#d04437}Cache 1{color} [[tests 1 TIMEOUT , Out Of Memory Error , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=5985690]]
* IgniteBinaryCacheTestSuite: DataStreamProcessorPersistenceBinarySelfTest.testReplicatedIsolated - Test has low fail rate in base branch 0,0% and is not flaky

{color:#d04437}Platform C++ CMake (Win x64 / Release){color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=5985730]]
* IgniteCoreTest: ComputeTestSuite: IgniteCallAsyncLocalError - Test has low fail rate in base branch 0,0% and is not flaky

{color:#d04437}Platform C++ CMake (Linux Clang){color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=5985726]]
* IgniteCoreTest: ComputeTestSuite: IgniteRunRemoteError - Test has low fail rate in base branch 0,0% and is not flaky

{color:#d04437}Platform .NET (Inspections)*{color} [[tests 0 Failure on metric |https://ci.ignite.apache.org/viewLog.html?buildId=5985711]]

{panel}
{panel:title=Branch: [pull/9058/head] Base: [master] : New Tests (13)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Platform .NET (Core Linux){color} [[tests 7|https://ci.ignite.apache.org/viewLog.html?buildId=5985710]]
* {color:#013220}dll: DataStreamerTest.TestDestroyCacheObsolete - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestFlushAsync - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestAutoFlushObsolete - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestDestroyCache - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestStreamerAsyncAwait - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestTryFlushObsolete - PASSED{color}
* {color:#013220}dll: DataStreamerTest.TestAddRemoveObsolete - PASSED{color}

{color:#00008b}Platform .NET{color} [[tests 6|https://ci.ignite.apache.org/viewLog.html?buildId=5985709]]
* {color:#013220}exe: DataStreamerTest.TestFlushAsync - PASSED{color}
* {color:#013220}exe: DataStreamerTest.TestTryFlushObsolete - PASSED{color}
* {color:#013220}exe: DataStreamerTest.TestDestroyCache - PASSED{color}
* {color:#013220}exe: DataStreamerTest.TestDestroyCacheObsolete - PASSED{color}
* {color:#013220}exe: DataStreamerTest.TestAddRemoveObsolete - PASSED{color}
* {color:#013220}exe: DataStreamerTest.TestAutoFlushObsolete - PASSED{color}

{panel}
[TeamCity *--&gt; Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5985736&amp;buildTypeId=IgniteTests24Java8_RunAll]

> .NET: Do not return task from IDataStreamer.AddData method
> ----------------------------------------------------------
>
>                 Key: IGNITE-14655
>                 URL: https://issues.apache.org/jira/browse/IGNITE-14655
>             Project: Ignite
>          Issue Type: Improvement
>          Components: platforms
>            Reporter: Pavel Tupitsyn
>            Assignee: Pavel Tupitsyn
>            Priority: Major
>              Labels: .NET
>             Fix For: 2.11
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, all {{AddData}} methods return a Task, however, this task is not for an individual add/remove operation, but for the current batch.
> This is confusing: users often try to {{await}} the returned task, which is natural; but the task will never complete, because the batch is not yet full, and user code is stuck waiting.
> * Deprecate {{AddData}}, {{RemoveData}} methods
> * Add new {{void Add}} and {{void Remove}} methods
> * Add new {{BatchTask}} property to get the task for the current batch



--
This message was sent by Atlassian Jira
(v8.3.4#803005)