You are viewing a plain text version of this content. The canonical link for it is here.
Posted to discuss-archive@tvm.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2026/01/01 15:40:40 UTC

[PR] fix: integer overflow in GetDataSize [tvm-ffi]

guan404ming opened a new pull request, #375:
URL: https://github.com/apache/tvm-ffi/pull/375

   ## Why
   
   Integer overflow in `GetDataSize` function causes incorrect buffer size calculation when computing data size for tensors with large element counts, leading to buffer underallocation and potential heap overflow.
   
   ## How
   
   - Add overflow check before multiplication
   - Handle edge case where numel is zero to avoid division by zero
   - Add tests for overflow detection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org


Re: [PR] fix: add bounds checking for size() and stride() methods [tvm-ffi]

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #375:
URL: https://github.com/apache/tvm-ffi/pull/375


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org


Re: [PR] fix: integer overflow in GetDataSize [tvm-ffi]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #375:
URL: https://github.com/apache/tvm-ffi/pull/375#discussion_r2656440448


##########
include/tvm/ffi/container/tensor.h:
##########
@@ -325,7 +325,12 @@ class Tensor : public ObjectRef {
    */
   int64_t size(int64_t idx) const {
     const TensorObj* ptr = get();
-    return ptr->shape[idx >= 0 ? idx : (ptr->ndim + idx)];
+    int64_t adjusted_idx = idx >= 0 ? idx : (ptr->ndim + idx);
+    if (adjusted_idx < 0 || adjusted_idx >= ptr->ndim) {
+      TVM_FFI_THROW(IndexError) << "Index " << idx << " out of bounds for tensor with " << ptr->ndim
+                                << " dimensions";
+    }
+    return ptr->shape[adjusted_idx];
   }

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   The index adjustment and bounds checking logic is duplicated in `Tensor::size`, `Tensor::stride`, `TensorView::size`, and `TensorView::stride`. To improve maintainability and reduce code duplication, consider extracting this logic into a common helper function.
   
   For example, you could add a free helper function in a `details` namespace:
   ```cpp
   namespace tvm {
   namespace ffi {
   namespace details {
   inline int64_t CheckAndAdjustTensorIndex(int64_t idx, int32_t ndim) {
       int64_t adjusted_idx = idx >= 0 ? idx : (ndim + idx);
       if (adjusted_idx < 0 || adjusted_idx >= ndim) {
         TVM_FFI_THROW(IndexError) << "Index " << idx << " out of bounds for tensor with " << ndim
                                   << " dimensions";
       }
       return adjusted_idx;
   }
   } // namespace details
   } // namespace ffi
   } // namespace tvm
   ```
   Then `Tensor::size` and `TensorView::size` could be simplified to:
   ```cpp
   // Tensor::size
   int64_t size(int64_t idx) const {
     const TensorObj* ptr = get();
     return ptr->shape[details::CheckAndAdjustTensorIndex(idx, ptr->ndim)];
   }
   
   // TensorView::size
   int64_t size(int64_t idx) const {
     return tensor_.shape[details::CheckAndAdjustTensorIndex(idx, tensor_.ndim)];
   }
   ```
   A similar simplification would apply to the `stride` methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org


Re: [PR] fix: add bounds checking for size() and stride() methods [tvm-ffi]

Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #375:
URL: https://github.com/apache/tvm-ffi/pull/375#issuecomment-3704632557

   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org


Re: [PR] fix: add bounds checking for size() and stride() methods [tvm-ffi]

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #375:
URL: https://github.com/apache/tvm-ffi/pull/375#issuecomment-3703989885

   Given that we already have conditionals in `size()`, I'd say it won't add to too much overhead and happy to get it in


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org


Re: [PR] fix: integer overflow in GetDataSize [tvm-ffi]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #375:
URL: https://github.com/apache/tvm-ffi/pull/375#issuecomment-3703835899

   ## Summary of Changes
   
   Hello @guan404ming, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
   
   This pull request significantly improves the safety and reliability of tensor dimension access by introducing explicit index bounds checking to the `size` and `stride` methods within the `Tensor` and `TensorView` classes. These changes ensure that attempts to access dimensions with invalid indices will now correctly raise an `IndexError`, preventing potential runtime issues. Complementary C++ unit tests have been added to validate this new error-handling behavior. Additionally, minor type hinting updates were applied to Python test files for better code maintainability.
   
   ### Highlights
   
   * **Enhanced Index Safety**: Implemented robust index bounds checking for `size` and `stride` methods in both `Tensor` and `TensorView` classes, preventing out-of-bounds access.
   * **Improved Error Handling**: Modified `size` and `stride` methods to throw `tvm::ffi::IndexError` when an invalid index is provided, improving error detection and handling.
   * **Comprehensive Testing**: Added new C++ unit tests (`TEST(Tensor, SizeStrideOutOfBounds)`) to explicitly verify that out-of-bounds index access correctly triggers `tvm::ffi::Error` for these methods.
   * **Python Type Hinting**: Updated Python test files to use `numpy.typing` and `npt.NDArray[Any]` for improved type clarity and static analysis.
   
   🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
   
   
   
   
   
   
   
   <details>
   <summary><b>Using Gemini Code Assist</b></summary>
   <br>
   
   The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
   
   <b>Invoking Gemini</b>
   
   You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
   
   Feature | Command | Description
   --- | --- | ---
   Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
   Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
   Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
   Help | `/gemini help` | Displays a list of available commands.
   
   <b>Customization</b>
   
   To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
   
   <b>Limitations & Feedback</b>
   
   Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
   
   <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
   </details>
   
   
   
   
   [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org