[GitHub] liubao68 commented on issue #1017: [SCB-1056] put provider flow control logic in front

[GitBox <gi...@apache.org>]

liubao68 commented on issue #1017: [SCB-1056] put provider flow control logic in front
URL: https://github.com/apache/servicecomb-java-chassis/pull/1017#issuecomment-443069310
 
 
   I don't think change the handler execution sequence is a good idea. I got another solution for using handler logic alone. Here is an example : https://github.com/huaweicse/cse-java-chassis-samples/blob/master/porter/gateway-service/src/main/java/com/huawei/cse/porter/gateway/UiDispatcher.java
   
   I suggest add a configuration, e.g. servicecomb.flowcontrol.transport.enable to make flow controll logic executed before handler, and is a standalone logic, and you can resuse the code of handler. And the execution will not influence any handler logic(that's executed one by one, and if you configured flowcontrol handler, it will also be executed, that's twice execution). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services