[GitHub] [incubator-superset] nytai commented on a change in pull request #10994: chore: downgrade expected exception from error to info

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #10994:
URL: https://github.com/apache/incubator-superset/pull/10994#discussion_r492472899



##########
File path: superset/datasets/dao.py
##########
@@ -79,7 +79,7 @@ def validate_table_exists(database: Database, table_name: str, schema: str) -> b
             database.get_table(table_name, schema=schema)
             return True
         except SQLAlchemyError as ex:  # pragma: no cover
-            logger.error("Got an error %s validating table: %s", str(ex), table_name)
+            logger.info("Got an error %s validating table: %s", str(ex), table_name)

Review comment:
       since validation is expected to fail sometimes, it seems appropriate to log this a info instead of error. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org