[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #934: Delete dataTypeMapping etc fields in QueryPlan

[GitBox <gi...@apache.org>]

samperson1997 commented on a change in pull request #934: Delete dataTypeMapping etc fields in QueryPlan
URL: https://github.com/apache/incubator-iotdb/pull/934#discussion_r396967704
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
 ##########
 @@ -548,13 +548,13 @@ public TSDataType getSeriesType(String path) throws MetadataException {
 
 
   /**
-   * Get all devices under given prefixPath.
+   * Get all device nodes under given prefixPath.
    *
    * @param prefixPath a prefix of a full path. if the wildcard is not at the tail, then each
    * wildcard can only match one level, otherwise it can match to the tail.
-   * @return A HashSet instance which stores devices names with given prefixPath.
+   * @return A list which stores device nodes with given prefixPath.
    */
-  public Set<String> getDevices(String prefixPath) throws MetadataException {
+  public List<MNode> getDevices(String prefixPath) throws MetadataException {
 
 Review comment:
   Actually I think it's better to use `String` here so that you won't use `getFullPath()` when call this method ... What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services