You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2024/09/19 01:57:30 UTC
[PR] [minor](refactor) Remove duplicate code [doris]
Gabriel39 opened a new pull request, #40952:
URL: https://github.com/apache/doris/pull/40952
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Remove duplicate code [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #40952:
URL: https://github.com/apache/doris/pull/40952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Remove duplicate code [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #40952:
URL: https://github.com/apache/doris/pull/40952#issuecomment-2359821418
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Remove duplicate code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40952:
URL: https://github.com/apache/doris/pull/40952#issuecomment-2360572383
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Remove duplicate code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40952:
URL: https://github.com/apache/doris/pull/40952#issuecomment-2360572454
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Remove duplicate code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40952:
URL: https://github.com/apache/doris/pull/40952#issuecomment-2359821311
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Remove duplicate code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40952:
URL: https://github.com/apache/doris/pull/40952#issuecomment-2360454165
<details>
<summary>TPC-DS: <b>Total hot run time: 195020 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7ae30f085022445c393f15f207942c3bb23f8b96, data reload: false
query1 1249 907 867 867
query2 6325 2034 2086 2034
query3 10822 3955 3938 3938
query4 63765 26554 23492 23492
query5 5171 481 493 481
query6 400 172 175 172
query7 5464 305 294 294
query8 324 229 225 225
query9 8711 2658 2655 2655
query10 462 287 274 274
query11 17866 15032 15861 15032
query12 150 113 99 99
query13 1478 423 411 411
query14 10590 7520 7209 7209
query15 209 189 171 171
query16 6788 499 490 490
query17 1211 627 577 577
query18 1330 312 315 312
query19 220 158 155 155
query20 132 112 119 112
query21 220 105 104 104
query22 4715 4341 4823 4341
query23 34587 33878 33934 33878
query24 6032 2938 2892 2892
query25 506 399 430 399
query26 618 161 160 160
query27 1598 281 290 281
query28 4466 2456 2433 2433
query29 678 440 429 429
query30 232 155 154 154
query31 971 786 813 786
query32 71 56 54 54
query33 447 303 298 298
query34 903 500 498 498
query35 852 760 768 760
query36 1051 939 954 939
query37 149 89 90 89
query38 4020 3865 3948 3865
query39 1482 1422 1423 1422
query40 202 97 99 97
query41 52 48 50 48
query42 124 94 98 94
query43 525 494 485 485
query44 1156 814 791 791
query45 199 174 164 164
query46 1135 773 751 751
query47 1907 1812 1818 1812
query48 463 358 365 358
query49 708 422 428 422
query50 848 412 409 409
query51 7095 6819 6855 6819
query52 97 90 90 90
query53 256 182 186 182
query54 598 464 464 464
query55 79 77 79 77
query56 282 284 289 284
query57 1202 1099 1114 1099
query58 242 282 236 236
query59 3102 2851 2776 2776
query60 285 268 270 268
query61 102 100 100 100
query62 753 667 672 667
query63 229 181 189 181
query64 1258 644 617 617
query65 3258 3216 3180 3180
query66 680 291 296 291
query67 15753 15745 15533 15533
query68 4418 576 572 572
query69 453 301 305 301
query70 1175 1109 1133 1109
query71 367 279 270 270
query72 6418 3901 3962 3901
query73 782 327 349 327
query74 9653 9085 9108 9085
query75 3332 2669 2671 2669
query76 1789 897 891 891
query77 492 297 299 297
query78 9941 9164 11145 9164
query79 1111 551 554 551
query80 784 446 454 446
query81 519 235 242 235
query82 320 137 142 137
query83 156 137 135 135
query84 285 75 82 75
query85 857 287 273 273
query86 328 293 286 286
query87 4569 4385 4286 4286
query88 2935 2327 2354 2327
query89 388 283 290 283
query90 1949 185 188 185
query91 186 144 142 142
query92 63 47 48 47
query93 1045 529 537 529
query94 723 301 291 291
query95 340 250 254 250
query96 612 277 281 277
query97 3229 3134 3114 3114
query98 217 209 201 201
query99 1887 1287 1319 1287
Total cold run time: 310178 ms
Total hot run time: 195020 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Remove duplicate code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40952:
URL: https://github.com/apache/doris/pull/40952#issuecomment-2360426429
<details>
<summary>TPC-H: <b>Total hot run time: 41408 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7ae30f085022445c393f15f207942c3bb23f8b96, data reload: false
------ Round 1 ----------------------------------
q1 17768 7410 7281 7281
q2 2043 168 170 168
q3 10799 1075 1175 1075
q4 10367 712 666 666
q5 7773 3116 3093 3093
q6 238 150 149 149
q7 1003 612 606 606
q8 9444 2094 2060 2060
q9 6887 6436 6417 6417
q10 7023 2283 2284 2283
q11 435 239 237 237
q12 414 208 206 206
q13 17760 2977 2974 2974
q14 238 210 212 210
q15 569 521 516 516
q16 670 609 609 609
q17 989 806 809 806
q18 7469 6697 6749 6697
q19 1405 1061 1078 1061
q20 582 297 290 290
q21 4383 2995 3144 2995
q22 1117 1015 1009 1009
Total cold run time: 109376 ms
Total hot run time: 41408 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7254 7235 7232 7232
q2 328 230 233 230
q3 3050 3009 2979 2979
q4 2035 1879 1856 1856
q5 5589 5623 5616 5616
q6 244 149 144 144
q7 2196 1792 1777 1777
q8 3325 3461 3440 3440
q9 8752 8903 8766 8766
q10 3576 3429 3494 3429
q11 575 488 483 483
q12 808 619 602 602
q13 8676 3159 3152 3152
q14 301 277 278 277
q15 591 525 545 525
q16 712 677 685 677
q17 1810 1585 1579 1579
q18 8247 7892 7961 7892
q19 1754 1620 1496 1496
q20 2145 1899 1867 1867
q21 5681 5219 5346 5219
q22 1141 1033 1050 1033
Total cold run time: 68790 ms
Total hot run time: 60271 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Remove duplicate code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40952:
URL: https://github.com/apache/doris/pull/40952#issuecomment-2360465788
<details>
<summary>ClickBench: <b>Total hot run time: 32.16 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7ae30f085022445c393f15f207942c3bb23f8b96, data reload: false
query1 0.05 0.05 0.04
query2 0.06 0.03 0.03
query3 0.22 0.06 0.06
query4 1.66 0.10 0.10
query5 0.51 0.50 0.49
query6 1.14 0.73 0.72
query7 0.02 0.01 0.01
query8 0.04 0.03 0.03
query9 0.55 0.50 0.50
query10 0.57 0.57 0.55
query11 0.14 0.10 0.10
query12 0.13 0.11 0.10
query13 0.59 0.59 0.59
query14 2.98 2.95 2.96
query15 0.89 0.82 0.81
query16 0.38 0.40 0.38
query17 1.06 0.98 1.06
query18 0.19 0.19 0.19
query19 1.93 1.88 1.96
query20 0.01 0.01 0.01
query21 15.35 0.57 0.59
query22 2.37 1.85 1.93
query23 17.32 0.92 0.73
query24 3.15 0.46 1.23
query25 0.19 0.13 0.06
query26 0.36 0.14 0.14
query27 0.04 0.04 0.04
query28 10.82 1.10 1.07
query29 12.59 3.22 3.21
query30 0.25 0.06 0.05
query31 2.88 0.39 0.39
query32 3.27 0.45 0.45
query33 2.98 3.04 3.04
query34 16.99 4.39 4.39
query35 4.41 4.45 4.42
query36 0.67 0.48 0.49
query37 0.08 0.06 0.05
query38 0.04 0.04 0.03
query39 0.03 0.02 0.02
query40 0.16 0.12 0.12
query41 0.07 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 107.2 s
Total hot run time: 32.16 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Remove duplicate code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40952:
URL: https://github.com/apache/doris/pull/40952#issuecomment-2359859528
<details>
<summary>TPC-H: <b>Total hot run time: 41615 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7ae30f085022445c393f15f207942c3bb23f8b96, data reload: false
------ Round 1 ----------------------------------
q1 17589 7352 7309 7309
q2 2051 182 153 153
q3 10596 1053 1148 1053
q4 10218 745 824 745
q5 7775 3107 3093 3093
q6 238 148 149 148
q7 1019 598 600 598
q8 9425 2041 2059 2041
q9 6872 6464 6475 6464
q10 7051 2281 2343 2281
q11 449 254 244 244
q12 408 216 211 211
q13 17816 3033 3035 3033
q14 242 233 214 214
q15 600 524 536 524
q16 692 615 647 615
q17 1002 853 823 823
q18 7261 6651 6705 6651
q19 1401 935 1013 935
q20 573 298 290 290
q21 4001 3264 3172 3172
q22 1137 1019 1018 1018
Total cold run time: 108416 ms
Total hot run time: 41615 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7390 7355 7301 7301
q2 330 235 241 235
q3 3154 3106 3100 3100
q4 2100 1847 1934 1847
q5 5769 5789 5821 5789
q6 244 152 146 146
q7 2229 1841 1804 1804
q8 3380 3469 3440 3440
q9 8849 8913 8716 8716
q10 3555 3407 3435 3407
q11 575 485 486 485
q12 807 640 597 597
q13 16238 3147 3138 3138
q14 293 275 277 275
q15 587 534 520 520
q16 702 687 666 666
q17 1784 1581 1575 1575
q18 8214 7887 7863 7863
q19 1744 1558 1466 1466
q20 2092 1886 1859 1859
q21 5562 5376 5526 5376
q22 1143 1077 1053 1053
Total cold run time: 76741 ms
Total hot run time: 60658 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](refactor) Remove duplicate code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40952:
URL: https://github.com/apache/doris/pull/40952#issuecomment-2359865737
TeamCity be ut coverage result:
Function Coverage: 37.33% (9584/25675)
Line Coverage: 28.72% (79251/275953)
Region Coverage: 28.19% (41021/145531)
Branch Coverage: 24.81% (20907/84260)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7ae30f085022445c393f15f207942c3bb23f8b96_7ae30f085022445c393f15f207942c3bb23f8b96/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org